Skip to content

qemuimgutil: fix "Failed to get \"write\" lock" error #3742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 18, 2025
Merged

qemuimgutil: fix "Failed to get \"write\" lock" error #3742

merged 2 commits into from
Jul 18, 2025

Conversation

AkihiroSuda
Copy link
Member

Fix #3720

Thanks to @pavelanni for providing the fix generated by Claude

#3720 (comment)

@AkihiroSuda AkihiroSuda added this to the v2.0.0 milestone Jul 17, 2025
@AkihiroSuda AkihiroSuda mentioned this pull request Jul 17, 2025
Closed
alexandear
alexandear reviewed Jul 17, 2025
View reviewed changes
alexandear
alexandear approved these changes Jul 17, 2025
View reviewed changes
Copy link
Member

@alexandear alexandear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix lint issues.

@afbjorklund
Copy link
Member

afbjorklund commented Jul 17, 2025 •
edited
Loading

Please fix lint issues.

Why does the code pass with "golangci-lint has version 2.2.1", but fail with golangci-lint 2.2.2? It's not changed.

Error: pkg\instance\start.go:274:65: SA4023: this comparison is always true (staticcheck)
  		if err := syscall.Exec(limactl, haCmd.Args, haCmd.Environ()); err != nil {

@alexandear
Copy link
Member

Please fix lint issues.

Why does the code pass with "golangci-lint has version 2.2.1", but fail with golangci-lint 2.2.2? It's not changed.

Error: pkg\instance\start.go:274:65: SA4023: this comparison is always true (staticcheck)
  		if err := syscall.Exec(limactl, haCmd.Args, haCmd.Environ()); err != nil {

It seems that golangci-lint v2.2.2 has improved detection: syscall.Exec always returns an error on Windows.

@AkihiroSuda
Copy link
Member Author

This PR doesn't touch pkg\instance\start.go.
Why is the lint passing for master? 🤔

@AkihiroSuda @alexandear
qemuimgutil: fix "Failed to get \"write\" lock" error
2b8bb39 
Fix issue 3720

Thanks to pavelanni for providing the fix generated by Claude

Co-authored-by: Oleksandr Redko <[email protected]>
Signed-off-by: Akihiro Suda <[email protected]>
@AkihiroSuda
Copy link
Member Author

Pushed a fix anyway

@afbjorklund
Copy link
Member

Probably should not auto-update linters if we want a stable CI

@AkihiroSuda
pkg/instance/start.go: fix lint error on windows
bdf7c7f 
```
Error: pkg\instance\start.go:274:65: SA4023: this comparison is always true (staticcheck)
  		if err := syscall.Exec(limactl, haCmd.Args, haCmd.Environ()); err != nil {
```

Signed-off-by: Akihiro Suda <[email protected]>
@afbjorklund
Copy link
Member

afbjorklund commented Jul 17, 2025 •
edited
Loading

Why is the lint passing for master? 🤔

Master also used golangci-lint 2.2.2

https://github.com/lima-vm/lima/actions/runs/16348933473/job/46190196998

Run actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5
Run golangci/golangci-lint-action@4afd733a84b1f43292c63897423277bb7f4313a9

https://github.com/lima-vm/lima/actions/runs/16344481091/job/46174596915

Run actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5
Run golangci/golangci-lint-action@4afd733a84b1f43292c63897423277bb7f4313a9

Seems a bit flakey. even if warning is true

@AkihiroSuda AkihiroSuda requested review from alexandear, a team and afbjorklund July 17, 2025 23:44
@AkihiroSuda AkihiroSuda merged commit 1381317 into lima-vm:master Jul 18, 2025
62 of 63 checks passed
@AkihiroSuda AkihiroSuda mentioned this pull request Jul 18, 2025
Merged
@afbjorklund afbjorklund mentioned this pull request Jul 19, 2025
Open
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Jul 27, 2025
@tmeijn
build(deps): update lima-vm/lima to v1.2.1
c11b8ee 
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [lima-vm/lima](https://github.com/lima-vm/lima) | minor | `v1.1.1` -> `v1.2.1` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>lima-vm/lima (lima-vm/lima)</summary>

### [`v1.2.1`](https://github.com/lima-vm/lima/releases/tag/v1.2.1)

[Compare Source](lima-vm/lima@v1.2.0...v1.2.1)

#### Changes

- Cherry-picks from `master` to `release/1.2` ([#&#8203;3750](lima-vm/lima#3750))
  - portfwd: create separate gRPC streams for each UDP client ([#&#8203;3724](lima-vm/lima#3724), thanks to [@&#8203;stek29](https://github.com/stek29))
  - qemuimgutil: fix "Failed to get "write" lock" error ([#&#8203;3742](lima-vm/lima#3742), thanks to [@&#8203;pavelanni](https://github.com/pavelanni))
  - Embed templates edited from the user interface ([#&#8203;3745](lima-vm/lima#3745), thanks to [@&#8203;afbjorklund](https://github.com/afbjorklund))

#### Usage

```console
$ limactl create
$ limactl start
...
INFO[0029] READY. Run `lima` to open the shell.

$ lima uname
Linux
```

***

The binaries were built automatically on GitHub Actions.
The build log is available for 90 days: https://github.com/lima-vm/lima/actions/runs/16405168554

The sha256sum of the SHA256SUMS file itself is `fda636e062d8f75a689071b308a94dc902111620f7122746fc0d172959d7d26a` .

***

Release manager: [@&#8203;AkihiroSuda](https://github.com/AkihiroSuda)

### [`v1.2.0`](https://github.com/lima-vm/lima/releases/tag/v1.2.0)

[Compare Source](lima-vm/lima@v1.1.1...v1.2.0)

#### Changes

- `limactl` CLI:
  - Add `limactl network (list|create|delete)` commands ([#&#8203;3677](lima-vm/lima#3677))
  - Add `limactl clone OLDINST NEWINST` command. Not to be confused with `limactl copy`, which copies files. ([#&#8203;3673](lima-vm/lima#3673))
  - Add `limactl edit --mount-none` flag ([#&#8203;3647](lima-vm/lima#3647))
- Port forwarding:
  - Improve stability ([#&#8203;3684](lima-vm/lima#3684). [#&#8203;3708](lima-vm/lima#3708), thanks to [@&#8203;balajiv113](https://github.com/balajiv113))
  - De-deprecate `LIMA_SSH_PORT_FORWARDER` that was once deprecated in v1.1 ([#&#8203;3709](lima-vm/lima#3709))
- nerdctl:
  - Update from v2.1.2 to [v2.1.3](https://github.com/containerd/nerdctl/releases/tag/v2.1.3) ([#&#8203;3701](lima-vm/lima#3701))
- Templates:
  - `default`: update from Ubuntu 24.10 to 25.04 ([#&#8203;3643](lima-vm/lima#3643))
  - `fedora`: update from Fedora 41 to 42 ([#&#8203;3643](lima-vm/lima#3643))
  - `almalinux-10`: new template ([#&#8203;3602](lima-vm/lima#3602), thanks to [@&#8203;refi64](https://github.com/refi64))
  - `rocky-10`: new template ([#&#8203;3642](lima-vm/lima#3642))
  - `experimental/debian-testing`: new template ([#&#8203;3645](lima-vm/lima#3645))
  - `experimental/ubuntu-next`: new template ([#&#8203;3645](lima-vm/lima#3645))
- Makefile:
  - Kconfig: deprecate ([#&#8203;3706](lima-vm/lima#3706))

> \[!NOTE]
> On Intel Mac, macOS 15.5 or later is needed to boot the default Ubuntu 25.04 template.
>
> Workarounds for macOS <= 15.4 :
>
> - Option 1: Use QEMU
>
> ```
> limactl create --vm-type=qemu
> ```
>
> - Option2: Use Ubuntu 24.04 template
>
> ```
> limactl create --name=default template://ubuntu-24.04
> ```

Full changes: https://github.com/lima-vm/lima/milestone/61?closed=1

Thanks to
[@&#8203;AkinoKaede](https://github.com/AkinoKaede) [@&#8203;Horiodino](https://github.com/Horiodino) [@&#8203;afbjorklund](https://github.com/afbjorklund) [@&#8203;alexandear](https://github.com/alexandear) [@&#8203;arixmkii](https://github.com/arixmkii) [@&#8203;balajiv113](https://github.com/balajiv113) [@&#8203;fruzitent](https://github.com/fruzitent) [@&#8203;jandubois](https://github.com/jandubois) [@&#8203;kachick](https://github.com/kachick) [@&#8203;mazzz1y](https://github.com/mazzz1y) [@&#8203;nirs](https://github.com/nirs) [@&#8203;refi64](https://github.com/refi64) [@&#8203;songponssw](https://github.com/songponssw) [@&#8203;thomasjm](https://github.com/thomasjm) [@&#8203;unsuman](https://github.com/unsuman)

#### Usage

```console
$ limactl create
$ limactl start
...
INFO[0029] READY. Run `lima` to open the shell.

$ lima uname
Linux
```

***

The binaries were built automatically on GitHub Actions.
The build log is available for 90 days: https://github.com/lima-vm/lima/actions/runs/16187325385

The sha256sum of the SHA256SUMS file itself is `f4d57cdd637022ead291af680c0c88a8d07fd35fd6a779b7c6348e2c9a2ec2cc` .

***

Release manager: [@&#8203;AkihiroSuda](https://github.com/AkihiroSuda)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MC42Mi4xIiwidXBkYXRlZEluVmVyIjoiNDAuNjIuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afbjorklund afbjorklund Awaiting requested review from afbjorklund

1 more reviewer

@alexandear alexandear alexandear approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cherry-pick/done cherry-pick/v1.2
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

Cannot create a VM with additional disks; qemu-img convert fails to convert to raw
3 participants
@AkihiroSuda @afbjorklund @alexandear