Skip to content

lima-guestagent: support external trigger via sighup notification #3766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

lima-guestagent: support external trigger via sighup notification #3766

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57742e2
lima-guestagent: support external trigger via sighup notification
ciderale Jul 21, 2025
609de13
lima-guestagent: improve SIGHUP handler description & log message
ciderale Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 39 additions & 1 deletion cmd/lima-guestagent/daemon_linux.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
"errors"
"net"
"os"
"os/signal"
"syscall"
"time"

"github.com/mdlayher/vsock"
Expand Down Expand Up @@ -58,7 +60,43 @@
// without depending on `bpftrace` binary.
// The agent binary will need CAP_BPF file cap.
ticker := time.NewTicker(tick)
return ticker.C, ticker.Stop

logrus.Info("register for sighup notifications")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: probably sighup should be spelled in the upper chars, as it might look like "sigh up" (?) or a typo of sign-up

sighupC := make(chan os.Signal, 1)
signal.Notify(sighupC, syscall.SIGHUP)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment line to explain who sends SIGHUP

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I have added a comment about the purpose of the SIGHUP mechanism and also improved the log message.


c := make(chan time.Time, 1)
go func() {
defer close(c)
defer close(sighupC)
for {
select {
case _, ok := <-sighupC:
if !ok {
logrus.Info("Sighup channel closed")
sighupC = nil;

Check failure on line 77 in cmd/lima-guestagent/daemon_linux.go

View workflow job for this annotation

GitHub Actions / Lint Go (ubuntu-24.04) 

File is not properly formatted (gci)
} else {
logrus.Debug("Sighup received")
c <- time.Now()
}
case now, ok := <-ticker.C:
if !ok {
break;
} else {
c <- now
}
}
}
logrus.Info("ticker stopped")

Check failure on line 90 in cmd/lima-guestagent/daemon_linux.go

View workflow job for this annotation

GitHub Actions / Lint Go (ubuntu-24.04) 

unreachable: unreachable code (govet)
}()

stop := func() {
logrus.Info("stopping ticker")
ticker.Stop()
signal.Stop(sighupC)
}

return c, stop
}

agent, err := guestagent.New(newTicker, tick*20)
Expand Down
Loading