-
Notifications
You must be signed in to change notification settings - Fork 693
docs: clarify maintainers' affiliation #3803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fix issue 3794 Signed-off-by: Akihiro Suda <[email protected]>
| Balaji Vijayakumar | Thoughtworks | Committer | [@balajiv113](https://github.com/balajiv113) | [80E1 01FE 5C89 FCF6 6171 72C8 377C 6A63 934B 8E6E](https://github.com/balajiv113.gpg) | | ||
| Oleksandr Redko | Individual | Reviewer | [@alexandear](https://github.com/alexandear) | [50F8 9811 D8D8 3E79 3E7E 0680 A947 E3F1 1A61 2A57](https://github.com/alexandear.gpg) | | ||
| Norio Nomura | Individual | Reviewer | [@norio-nomura](https://github.com/norio-nomura) | [0010 36FA 2504 DBFF 37BA 2EF8 D4A7 318E B7F7 138D](https://github.com/norio-nomura.gpg) | | ||
| Nir Soffer | IBM | Reviewer | [@nirs](https://github.com/nirs) | [6F81 B717 51A1 4171 4C09 AF19 4C67 29D7 B2DD 8AFF](https://github.com/nirs.gpg) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nirs PTAL, for confirmation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nirs PTAL, for confirmation
Looks good, I hope you got the gpg fingerprint right, I don't really use it for anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this key expired, or did I accidentally put somebody else's key in the first place? 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is my key details:
% gpg --export --armor
-----BEGIN PGP PUBLIC KEY BLOCK-----
mDMEZztZ+hYJKwYBBAHaRw8BAQdALUcOEcTDM3op9aLCTZwflZXUfUNY0jplAt0a
AoK2e220HU5pciBTb2ZmZXIgPG5pcnNvZkBnbWFpbC5jb20+iJkEExYKAEEWIQRH
WJcqkUO4C/oimgoeZoeAPl1oNwUCZztZ+gIbAwUJBaOagAULCQgHAgIiAgYVCgkI
CwIEFgIDAQIeBwIXgAAKCRAeZoeAPl1oN+oMAP4uUimsxBxSgADJ8JvE//z0xMIw
g+YraYp3Zy4rljstpwEAtJk8R4HlonR686im4F5UQ3qXSq07e7BE05skQd4RgQ64
OARnO1n6EgorBgEEAZdVAQUBAQdAhgz0noHpv0A/HKNDiVBotD4HTbznk324CyrO
vyc+4XsDAQgHiH4EGBYKACYWIQRHWJcqkUO4C/oimgoeZoeAPl1oNwUCZztZ+gIb
DAUJBaOagAAKCRAeZoeAPl1oNyMhAQDF90r/zSfj46n6hUrm022XHAFCtLv9b562
LgBEbITYsgEAruCWZ44xEYBRtpxBTjVGySyorhlIJ0d6sWYCABR4Ygo=
=KFAJ
-----END PGP PUBLIC KEY BLOCK-----
% gpg --fingerprint
[keyboxd]
---------
pub ed25519 2024-11-18 [SC] [expires: 2027-11-18]
4758 972A 9143 B80B FA22 9A0A 1E66 8780 3E5D 6837
uid [ultimate] Nir Soffer <[email protected]>
sub cv25519 2024-11-18 [E] [expires: 2027-11-18]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cc @jandubois for confirming the key
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I don't understand how this works, but this is how I got the fingerprint:
❯ wget -q https://github.com/nirs.gpg
❯ gpg --show-keys --with-fingerprint nirs.gpg
pub ed25519 2024-11-18 [SC] [expires: 2027-11-18]
6F81 B717 51A1 4171 4C09 AF19 4C67 29D7 B2DD 8AFF
uid Nir Soffer <[email protected]>
sub cv25519 2024-11-18 [E] [expires: 2027-11-18]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what I get locally:
% gpg --export --armor > nir.gpg
% gpg --show-keys --with-fingerprint nir.gpg
pub ed25519 2024-11-18 [SC] [expires: 2027-11-18]
4758 972A 9143 B80B FA22 9A0A 1E66 8780 3E5D 6837
uid Nir Soffer <[email protected]>
sub cv25519 2024-11-18 [E] [expires: 2027-11-18]
Maybe I generated a new key locally, I remember I had some trouble to create the key in the way I wanted it.
I can upload the current key to GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I uploaded the key to GitHub and remove the old key since I don't have the private key now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed
❯ rm nirs.gpg
❯ wget -q https://github.com/nirs.gpg
❯ gpg --show-keys --with-fingerprint nirs.gpg
pub ed25519 2024-11-18 [SC] [expires: 2027-11-18]
4758 972A 9143 B80B FA22 9A0A 1E66 8780 3E5D 6837
uid Nir Soffer <[email protected]>
sub cv25519 2024-11-18 [E] [expires: 2027-11-18]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've merged this PR.
@nirs Please send a PR to update your fingerprint!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
Fix #3794