Skip to content

Fix creating bridged network interface in limactl #3813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix creating bridged network interface in limactl #3813

wants to merge 2 commits into from
+19 −19

Conversation

dharsanb
Copy link

@dharsanb dharsanb commented Aug 9, 2025

Fixes: #3782

@dharsanb
Copy link
Author

dharsanb commented Aug 9, 2025

Can I get some help here please.
Thanks.

nirs
nirs reviewed Aug 10, 2025
View reviewed changes
Copy link
Member

@nirs nirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why you change code not related to bridged mode. The best way to fix this is to add a failing test and then add a minimal fix for the bridged case.

jandubois
jandubois reviewed Aug 11, 2025
View reviewed changes
Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me, but please squash commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jandubois jandubois jandubois left review comments

@nirs nirs nirs left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Creating a new bridged network results in an error.
3 participants
@dharsanb @jandubois @nirs