-
Notifications
You must be signed in to change notification settings - Fork 806
Disable env access and file load operations in yqlib #4405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4760909 to
7ccc8f1
Compare
Signed-off-by: Jan Dubois <jan.dubois@suse.com>
7ccc8f1 to
43df949
Compare
I've rebased the PR on latest
I'm struggling to find a good place in the documentation for this. Like a place users would actually find. I feel like we also need more documentation for the This might still be a bit unwieldy, so maybe we should start having "concept guides" the way ❯ git help -g
The Git concept guides are:
core-tutorial A Git core tutorial for developers
credentials Providing usernames and passwords to Git
cvs-migration Git for CVS users
diffcore Tweaking diff output
everyday A useful minimum set of commands for Everyday Git
faq Frequently asked questions about using Git
glossary A Git Glossary
namespaces Git namespaces
remote-helpers Helper programs to interact with remote repositories
submodules Mounting one repository inside another
tutorial A tutorial introduction to Git
tutorial-2 A tutorial introduction to Git: part two
workflows An overview of recommended workflows with Git
'git help -a' and 'git help -g' list available subcommands and some
concept guides. See 'git help <command>' or 'git help <concept>'
to read about a specific subcommand or concept.
See 'git help git' for an overview of the system.There is also Anyways, this is quickly becoming out-of-scope for this PR and should be in a separate docs PR. |
|
Is this PR still a draft?
This can be probably implemented using https://pkg.go.dev/github.com/spf13/cobra#Command.IsAdditionalHelpTopicCommand |
I turned it into a draft because we said yesterday it needs documentation before it can be merged, and the documentation is still outstanding (see my comments above). The code is complete, if you are willing to create an issue for the docs and merge the code as-is. |
AkihiroSuda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Before:
After:
Addresses objections to using YQ expressions for
limactl list --filterin #4187.