Add allow-env and block-env option for limactl shell #4483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
reviewed
Dec 21, 2025
cmd/limactl/shell.go
Outdated
| shellCmd.Flags().Bool("reconnect", false, "Reconnect to the SSH session") | ||
| shellCmd.Flags().Bool("preserve-env", false, "Propagate environment variables to the shell") | ||
| shellCmd.Flags().Bool("start", false, "Start the instance if it is not already running") | ||
| shellCmd.Flags().String("allow-env", "", "Comma-separated list of environment variable patterns to allow when --preserve-env is set (overrides LIMA_SHELLENV_ALLOW)") |
Member
There was a problem hiding this comment.
vax-r
force-pushed
the
shell_option
branch
2 times, most recently
from
f662f04 to
124a66f
Compare
Implement allow-env and block-env option for limactl shell command, which is equivalent of setting environment variable "LIMA_SHELLENV_ALLOW" and "LIMA_SHELLENV_BLOCK". Except that "allow-env" and "block-env" are treated as StringSlice rather than pure string in these options. Related issue: lima-vm#4263 Signed-off-by: I Hsin Cheng <[email protected]>
Contributor
Author
|
@AkihiroSuda Btw, the test starting WSL2 seems to fail, I've read the log I don't think it's triggered by this commit change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implement allow-env and block-env option for limactl shell command, which is equivalent of setting
environment variable "LIMA_SHELLENV_ALLOW" and
"LIMA_SHELLENV_BLOCK".
Related issue
#4263