Skip to content

Fix inotify path translation for different mountPoint #4504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
balajiv113 merged 1 commit into from
Jan 12, 2026
Merged

Fix inotify path translation for different mountPoint #4504

balajiv113 merged 1 commit into from
Jan 12, 2026

Conversation

@TatsuyaHayashino
Copy link
Contributor

@TatsuyaHayashino TatsuyaHayashino commented Jan 5, 2026

This change fixes the issue where inotify events are not properly detected when mount location and mountPoint differ.

Fixes #3871

@TatsuyaHayashino
Copy link
Contributor Author

TatsuyaHayashino commented Jan 5, 2026

E2E Tests result

Test configuration:

mounts:
  - location: "~/lima-test-source"
    mountPoint: "/mnt/test-destination"
    writable: true
mountInotify: true

test result

run inotifywait command and run touch ~/lima-test-source/file.txt

❯ ./_output/bin/limactl shell default -- inotifywait -m /mnt/test-destination/
WARN[0000] treating lima version "08ee74e8" from "/Users/tatsuya/.lima/default/lima-version" as very latest release 
Setting up watches.
Watches established.
/mnt/test-destination/ ATTRIB file.txt

@TatsuyaHayashino
Fix inotify path translation for different mountPoint
36dd263 
This change fixes the issue where inotify events are not properly
detected when mount location and mountPoint differ.

Fixes lima-vm#3871

Signed-off-by: Tatsuya Hayashino <tatsuya.hayashino@gmail.com>
@AkihiroSuda AkihiroSuda requested a review from balajiv113 January 6, 2026 15:46
@AkihiroSuda AkihiroSuda added this to the v2.1.0 milestone Jan 6, 2026
balajiv113
balajiv113 approved these changes Jan 11, 2026
View reviewed changes
Copy link
Member

@balajiv113 balajiv113 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@AkihiroSuda
Copy link
Member

AkihiroSuda commented Jan 11, 2026

@balajiv113 You can merge PRs 🙂

@balajiv113 balajiv113 merged commit 1dd6133 into lima-vm:master Jan 12, 2026
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@balajiv113 balajiv113 balajiv113 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v2.1.0

Development

Successfully merging this pull request may close these issues.

iNotify only works when mountPoint is the same as location

3 participants

@TatsuyaHayashino @AkihiroSuda @balajiv113