Return IsbnError::InvalidChecksum instead of InvalidDigit when parsing#13
Open
bpeel wants to merge 5 commits intolimeburst:mainfrom
Open
Return IsbnError::InvalidChecksum instead of InvalidDigit when parsing#13bpeel wants to merge 5 commits intolimeburst:mainfrom
bpeel wants to merge 5 commits intolimeburst:mainfrom
Conversation
Update dependencies
The constructors for Isbn13 and Isbn10 already check the check digit as well so it is redundant to check it in Parser as well. This also changes the error value when the checksum is wrong to be InvalidChecksum instead of InvalidDigit which I think makes more sense.
Owner
|
Sorry about the year long delay! Could you update the pull request so that conflicts are resolved? Thank you so much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think if any developers see the
InvalidChecksumerror in the docs they would expect theFromStrimplementation to return that if the checksum is invalid. Currently it returnsInvalidDigitinstead, which is confusing. This PR changes that.