Skip to content

feat: Skip extract file content with txt or markdown file ✨ #2898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lethemanh wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: Skip extract file content with txt or markdown file ✨ #2898

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
194 changes: 54 additions & 140 deletions packages/cozy-viewer/src/Panel/AI/AIAssistantPanel.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,25 +5,23 @@ import { useLocation, useNavigate } from 'react-router-dom'
import { useI18n } from 'twake-i18n'

import { useClient } from 'cozy-client'
import { extractText, chatCompletion } from 'cozy-client/dist/models/ai'
import { chatCompletion } from 'cozy-client/dist/models/ai'
import { fetchBlobFileById } from 'cozy-client/dist/models/file'
import flag from 'cozy-flags'
import logger from 'cozy-logger'
import Button from 'cozy-ui/transpiled/react/Buttons'
import Icon from 'cozy-ui/transpiled/react/Icon'
import IconButton from 'cozy-ui/transpiled/react/IconButton'
import AssistantIcon from 'cozy-ui/transpiled/react/Icons/Assistant'
import CopyIcon from 'cozy-ui/transpiled/react/Icons/Copy'
import CrossMediumIcon from 'cozy-ui/transpiled/react/Icons/CrossMedium'
import RefreshIcon from 'cozy-ui/transpiled/react/Icons/Refresh'
import Paper from 'cozy-ui/transpiled/react/Paper'
import Stack from 'cozy-ui/transpiled/react/Stack'
import Typography from 'cozy-ui/transpiled/react/Typography'
import { useAlert } from 'cozy-ui/transpiled/react/providers/Alert'

import LoadingState from './LoadingState'
import PanelHeader from './PanelHeader'
import SummaryContent from './SummaryContent'
import {
extractFileContent,
validateContentSize,
getErrorMessage
} from './helpers'
import { SUMMARY_SYSTEM_PROMPT, getSummaryUserPrompt } from './prompts'
import styles from './styles.styl'
import { roughTokensEstimation } from '../../helpers'
import { useViewer } from '../../providers/ViewerProvider'

const AIAssistantPanel = ({ className }) => {
Expand Down Expand Up @@ -52,22 +50,10 @@ const AIAssistantPanel = ({ className }) => {
const summarizeFile = async ({ client, file, stream = false, model }) => {
try {
const fileBlob = await fetchBlobFileById(client, file?._id)
const textContent = await extractFileContent(client, fileBlob, file)

const rawTextContent = await extractText(client, fileBlob, {
name: file.name,
mime: file.mime
})
const textContent = rawTextContent ? JSON.stringify(rawTextContent) : ''

const summaryConfig = flag('drive.summary')
if (
summaryConfig?.maxTokens &&
roughTokensEstimation(textContent) > summaryConfig.maxTokens
) {
const error = new Error('DOCUMENT_TOO_LARGE')
error.code = 'DOCUMENT_TOO_LARGE'
throw error
}
const { maxTokens } = flag('drive.summary') ?? {}
validateContentSize(textContent, maxTokens)

const messages = [
{ role: 'system', content: SUMMARY_SYSTEM_PROMPT },
Expand All @@ -89,23 +75,22 @@ const AIAssistantPanel = ({ className }) => {
}
}

const persistedSummary = async (
fileMetadata,
targetFileId,
summaryContent
) => {
try {
await client
.collection('io.cozy.files')
.updateMetadataAttribute(targetFileId, {
...fileMetadata,
description: summaryContent
})
fetchedFileIdRef.current = targetFileId
} catch (error) {
logger.error('Error when persisting summary to file metadata:', error)
}
}
const persistedSummary = useCallback(
async (fileMetadata, targetFileId, summaryContent) => {
try {
await client
.collection('io.cozy.files')
.updateMetadataAttribute(targetFileId, {
...fileMetadata,
description: summaryContent
})
fetchedFileIdRef.current = targetFileId
} catch (error) {
logger.error('Error when persisting summary to file metadata:', error)
}
},
[client]
)

useEffect(() => {
activeFileIdRef.current = file?._id || null
Expand Down Expand Up @@ -142,11 +127,7 @@ const AIAssistantPanel = ({ className }) => {
await persistedSummary(fileMetadata, targetFileId, summaryContent)
} catch (err) {
if (activeFileIdRef.current === targetFileId) {
const errorMessage =
err.code === 'DOCUMENT_TOO_LARGE'
? t('Viewer.ai.error.documentTooLarge')
: t('Viewer.ai.error.summary')
setError(errorMessage)
setError(getErrorMessage(err, t))
}
} finally {
if (inFlightFileIdRef.current === targetFileId) {
Expand All @@ -157,7 +138,7 @@ const AIAssistantPanel = ({ className }) => {
}
}
},
[client, file, t]
[client, file, persistedSummary, t]
)

const handleRefresh = () => {
Expand All @@ -177,102 +158,35 @@ const AIAssistantPanel = ({ className }) => {
}, [fetchSummary])

return (
<>
<Stack
spacing="s"
className={cx('u-flex u-flex-column u-h-100', className)}
<Stack
spacing="s"
className={cx('u-flex u-flex-column u-h-100', className)}
>
<Paper
className={cx({
'u-flex-grow-1': !isLoading
})}
elevation={2}
square
>
<Paper
className={cx({
'u-flex-grow-1': !isLoading
})}
elevation={2}
square
>
<div className="u-flex u-flex-items-center u-flex-justify-between u-h-3 u-ph-1 u-flex-shrink-0">
<Typography variant="h4">
<Icon icon={AssistantIcon} /> {t('Viewer.ai.panelTitle')}
</Typography>
<IconButton aria-label="Close AI Assistant" onClick={handleClose}>
<Icon icon={CrossMediumIcon} />
</IconButton>
</div>
{!isLoading && (
<Stack spacing="s" className="u-ph-1">
<div>
<div className="u-flex u-flex-items-center u-flex-justify-between u-mb-1">
<Typography variant="subtitle1">
{t('Viewer.ai.bodyText')}
</Typography>
<div className="u-flex">
<IconButton size="small" onClick={handleRefresh}>
<Icon icon={RefreshIcon} />
</IconButton>
{summary && (
<IconButton size="small" onClick={handleCopy}>
<Icon icon={CopyIcon} />
</IconButton>
)}
</div>
</div>
<Typography className="u-mb-1">
{error ? (
<span style={{ color: 'var(--errorColor)' }}>{error}</span>
) : (
summary
)}
</Typography>
{!isLoading && summary && (
<Typography variant="caption" color="textSecondary">
{t('Viewer.ai.footerText')}
</Typography>
)}
</div>
</Stack>
)}
</Paper>
{isLoading ? (
<>
<div className={styles.loaderContainer}>
<div className={styles.loaderBar} />
</div>
<div className="u-flex u-flex-items-center u-flex-justify-between u-ph-1">
<Typography
variant="body1"
className="u-flex u-flex-items-center"
>
<Icon
icon={AssistantIcon}
color="var(--primaryColor)"
className="u-mr-1"
/>
{t('Viewer.ai.loadingText')}
</Typography>
<Button
size="small"
variant="text"
color="default"
label={t('Viewer.ai.stop')}
onClick={handleClose}
/>
</div>
</>
) : null}
</Stack>
</>
<PanelHeader onClose={handleClose} t={t} />
{!isLoading && (
<SummaryContent
summary={summary}
error={error}
onRefresh={handleRefresh}
onCopy={handleCopy}
t={t}
/>
)}
</Paper>
{isLoading && <LoadingState onStop={handleClose} t={t} />}
</Stack>
)
}

AIAssistantPanel.propTypes = {
isLoading: PropTypes.bool,
summary: PropTypes.string,
onStop: PropTypes.func,
onSend: PropTypes.func
}

AIAssistantPanel.defaultProps = {
isLoading: false,
summary: ''
className: PropTypes.string
}

export default AIAssistantPanel
43 changes: 43 additions & 0 deletions packages/cozy-viewer/src/Panel/AI/LoadingState.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
import PropTypes from 'prop-types'
import React from 'react'

import Button from 'cozy-ui/transpiled/react/Buttons'
import Icon from 'cozy-ui/transpiled/react/Icon'
import AssistantIcon from 'cozy-ui/transpiled/react/Icons/Assistant'
import Typography from 'cozy-ui/transpiled/react/Typography'

import styles from './styles.styl'

const LoadingState = ({ onStop, t }) => {
return (
<>
<div className={styles.loaderContainer}>
<div className={styles.loaderBar} />
</div>
<div className="u-flex u-flex-items-center u-flex-justify-between u-ph-1">
<Typography variant="body1" className="u-flex u-flex-items-center">
<Icon
icon={AssistantIcon}
color="var(--primaryColor)"
className="u-mr-1"
/>
{t('Viewer.ai.loadingText')}
</Typography>
<Button
size="small"
variant="text"
color="default"
label={t('Viewer.ai.stop')}
onClick={onStop}
/>
</div>
</>
)
}

LoadingState.propTypes = {
onStop: PropTypes.func.isRequired,
t: PropTypes.func.isRequired
}

export default LoadingState
28 changes: 28 additions & 0 deletions packages/cozy-viewer/src/Panel/AI/PanelHeader.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
import PropTypes from 'prop-types'
import React from 'react'

import Icon from 'cozy-ui/transpiled/react/Icon'
import IconButton from 'cozy-ui/transpiled/react/IconButton'
import AssistantIcon from 'cozy-ui/transpiled/react/Icons/Assistant'
import CrossMediumIcon from 'cozy-ui/transpiled/react/Icons/CrossMedium'
import Typography from 'cozy-ui/transpiled/react/Typography'

const PanelHeader = ({ onClose, t }) => {
return (
<div className="u-flex u-flex-items-center u-flex-justify-between u-h-3 u-ph-1 u-flex-shrink-0">
<Typography variant="h4">
<Icon icon={AssistantIcon} /> {t('Viewer.ai.panelTitle')}
</Typography>
<IconButton aria-label="Close AI Assistant" onClick={onClose}>
<Icon icon={CrossMediumIcon} />
</IconButton>
</div>
)
}

PanelHeader.propTypes = {
onClose: PropTypes.func.isRequired,
t: PropTypes.func.isRequired
}

export default PanelHeader
53 changes: 53 additions & 0 deletions packages/cozy-viewer/src/Panel/AI/SummaryContent.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
import PropTypes from 'prop-types'
import React from 'react'

import Icon from 'cozy-ui/transpiled/react/Icon'
import IconButton from 'cozy-ui/transpiled/react/IconButton'
import CopyIcon from 'cozy-ui/transpiled/react/Icons/Copy'
import RefreshIcon from 'cozy-ui/transpiled/react/Icons/Refresh'
import Stack from 'cozy-ui/transpiled/react/Stack'
import Typography from 'cozy-ui/transpiled/react/Typography'

const SummaryContent = ({ summary, error, onRefresh, onCopy, t }) => {
return (
<Stack spacing="s" className="u-ph-1">
<div>
<div className="u-flex u-flex-items-center u-flex-justify-between u-mb-1">
<Typography variant="subtitle1">{t('Viewer.ai.bodyText')}</Typography>
<div className="u-flex">
<IconButton size="small" onClick={onRefresh}>
<Icon icon={RefreshIcon} />
</IconButton>
{summary && (
<IconButton size="small" onClick={onCopy}>
<Icon icon={CopyIcon} />
</IconButton>
)}
</div>
</div>
<Typography className="u-mb-1">
{error ? (
<span style={{ color: 'var(--errorColor)' }}>{error}</span>
) : (
summary
)}
</Typography>
{summary && (
<Typography variant="caption" color="textSecondary">
{t('Viewer.ai.footerText')}
</Typography>
)}
</div>
</Stack>
)
}

SummaryContent.propTypes = {
summary: PropTypes.string,
error: PropTypes.string,
onRefresh: PropTypes.func.isRequired,
onCopy: PropTypes.func.isRequired,
t: PropTypes.func.isRequired
}

export default SummaryContent
Loading
Loading