Skip to content

TF-4269 Enable sentry for iOS#4271

Open
dab246 wants to merge 29 commits intofeatures/tf-4268-enable-sentry-for-androidfrom
features/tf-4269-enable-sentry-for-ios
Open

TF-4269 Enable sentry for iOS#4271
dab246 wants to merge 29 commits intofeatures/tf-4268-enable-sentry-for-androidfrom
features/tf-4269-enable-sentry-for-ios

Conversation

@dab246
Copy link
Member

@dab246 dab246 commented Jan 23, 2026

@coderabbitai
Copy link

coderabbitai bot commented Jan 23, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch features/tf-4269-enable-sentry-for-ios

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

This PR has been deployed to https://linagora.github.io/tmail-flutter/4271.

Copy link
Collaborator

@tddang-linagora tddang-linagora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


https://github.com/linagora/tmail-flutter/blob/features/tf-4268-enable-sentry-for-android/lib/main/utils/ios_sharing_manager.dart

All logs in this file are warning log, but all information in this file that is saved to keychain is essential for NSE to handle incoming notification in background. If one ever fails, it will be invisible to both developers and users, making the push notification breaks silently.

  • Consider update the logs to error in necessary places.

@dab246 dab246 force-pushed the features/tf-4268-enable-sentry-for-android branch from 952501e to 22fed14 Compare February 2, 2026 12:21
dab246 and others added 19 commits February 11, 2026 11:54
…mes tracking warning `[sentry] [warning] FramesTrackingIntegration disabled: incompatible binding, SentryWidgetsFlutterBinding has not been instantiated. Please, use SentryWidgetsFlutterBinding.ensureInitialized() instead of WidgetsFlutterBinding.ensureInitialized()`
@dab246 dab246 force-pushed the features/tf-4268-enable-sentry-for-android branch from 1a5695b to df487c6 Compare February 11, 2026 05:13
@dab246 dab246 force-pushed the features/tf-4269-enable-sentry-for-ios branch from 1ae04ad to b6d0b6c Compare February 11, 2026 08:34
@dab246
Copy link
Member Author

dab246 commented Feb 11, 2026

  • Consider update the logs to error in necessary places.

Added

@hoangdat hoangdat force-pushed the features/tf-4268-enable-sentry-for-android branch from 8dad25d to c53d43a Compare February 24, 2026 07:44
@dab246 dab246 force-pushed the features/tf-4268-enable-sentry-for-android branch from ea6e5cf to 9c463ba Compare March 4, 2026 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants