Spam banner: apply larger interval each time it is shown#4386
Spam banner: apply larger interval each time it is shown#4386chibenwa wants to merge 1 commit intolinagora:masterfrom
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can use TruffleHog to scan for secrets in your code with verification capabilities.Add a TruffleHog config file (e.g. trufflehog-config.yml, trufflehog.yml) to your project to customize detectors and scanning behavior. The tool runs only when a config file is present. |
|
Cc @hoangdat |
|
Hi @chibenwa , I tried running your PR but it doesn't seem to be working as expected (see demo video). In my opinion, the logic for displaying this Spam banner also has many necessary conditions, so your fix isn't working. If you don't mind, we can help you fix this issue. Screen.Recording.2026-03-19.at.13.48.23.mov |
Please ;-) |
Problem: The spam banner was only storing a timestamp when the user explicitly dismissed it (close button or "view spam"). If the user manually marked spam emails as read instead, no timestamp was
stored, so the banner would reappear on every app resume.
Fix in get_spam_mailbox_cached_interactor.dart:
Now the 24h cooldown starts as soon as the banner is displayed, regardless of how the user handles it.