TF-4392 [Team Mailbox] Move email to Trash #4418
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| import 'package:jmap_dart_client/jmap/mail/mailbox/mailbox.dart'; | ||
| import 'package:jmap_dart_client/jmap/mail/mailbox/namespace.dart'; | ||
| import 'package:model/mailbox/presentation_mailbox.dart'; | ||
| import 'package:tmail_ui_user/features/mailbox/presentation/mailbox_controller.dart'; | ||
| import 'package:tmail_ui_user/features/mailbox/presentation/model/mailbox_node.dart'; | ||
| import 'package:tmail_ui_user/features/mailbox/presentation/model/mailbox_tree.dart'; | ||
| import 'package:tmail_ui_user/main/routes/route_navigation.dart'; | ||
|
|
||
| mixin HandleTeamMailboxMixin { | ||
| MailboxTree? get _teamMailboxesTree => | ||
| getBinding<MailboxController>()?.teamMailboxesTree.value; | ||
|
|
||
| MailboxNode? _findTeamMailboxNodeByNamespaceOnFirstLevel( | ||
| Namespace namespace, | ||
| ) { | ||
| return _teamMailboxesTree?.findNodeOnFirstLevel( | ||
| (node) => node.item.namespace == namespace, | ||
| ); | ||
| } | ||
|
|
||
| PresentationMailbox? _findDefaultMailboxInTeamMailbox({ | ||
| required Namespace namespace, | ||
| required String mailboxName, | ||
| }) { | ||
| final teamMailboxNode = | ||
| _findTeamMailboxNodeByNamespaceOnFirstLevel(namespace); | ||
| if (teamMailboxNode == null) return null; | ||
|
|
||
| final mailboxNode = teamMailboxNode.findNodeOnFirstLevel( | ||
| (node) => | ||
| node.mailboxNameAsString.toLowerCase() == mailboxName.toLowerCase(), | ||
| ); | ||
| if (mailboxNode == null) return null; | ||
|
|
||
| return mailboxNode.item; | ||
| } | ||
|
|
||
| MailboxId? findDefaultMailboxIdInTeamMailbox({ | ||
| required Namespace namespace, | ||
| required String mailboxName, | ||
| }) { | ||
| final teamMailbox = _findDefaultMailboxInTeamMailbox( | ||
| namespace: namespace, | ||
| mailboxName: mailboxName, | ||
| ); | ||
| return teamMailbox?.id; | ||
| } | ||
|
|
||
| String? getTeamMailboxNodePathWithSeparator({ | ||
| required MailboxId mailboxId, | ||
| String pathSeparator = '/', | ||
| }) { | ||
| return _teamMailboxesTree?.getNodePath(mailboxId, pathSeparator); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| import 'package:jmap_dart_client/jmap/mail/mailbox/mailbox.dart'; | ||
| import 'package:model/email/email_action_type.dart'; | ||
| import 'package:model/extensions/presentation_mailbox_extension.dart'; | ||
| import 'package:model/mailbox/presentation_mailbox.dart'; | ||
| import 'package:tmail_ui_user/features/email/domain/state/move_to_mailbox_state.dart'; | ||
| import 'package:tmail_ui_user/features/mailbox_dashboard/presentation/controller/mailbox_dashboard_controller.dart'; | ||
|
|
||
| extension GetTrashMailboxIdAndPathExtension on MailboxDashBoardController { | ||
| ({MailboxId? trashId, String? trashPath}) getTrashMailboxIdAndPath( | ||
| PresentationMailbox emailMailbox, | ||
| ) { | ||
| final defaultResult = ( | ||
| trashId: mapDefaultMailboxIdByRole[PresentationMailbox.roleTrash], | ||
| trashPath: null as String?, | ||
| ); | ||
|
|
||
| final mailbox = selectedMailbox.value ?? emailMailbox; | ||
|
|
||
| if (mailbox.isPersonal) return defaultResult; | ||
|
|
||
| final namespace = mailbox.namespace; | ||
| if (namespace == null) return defaultResult; | ||
|
|
||
| final trashId = findDefaultMailboxIdInTeamMailbox( | ||
| namespace: namespace, | ||
| mailboxName: PresentationMailbox.trashRole, | ||
| ); | ||
| if (trashId == null) return defaultResult; | ||
|
|
||
| final trashPath = getTeamMailboxNodePathWithSeparator( | ||
| mailboxId: trashId, | ||
| ); | ||
| return (trashId: trashId, trashPath: trashPath); | ||
| } | ||
|
|
||
| void emitMoveToTrashFailure(Exception exception) { | ||
| emitFailure( | ||
| controller: this, | ||
| failure: MoveToMailboxFailure( | ||
| EmailActionType.moveToTrash, | ||
| exception: exception, | ||
| ), | ||
| ); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Virtual folders still mask the real mailbox here.
mailboxDashBoardController.getMailboxContain(email)returnsselectedMailboxwhenever search isn't running (lib/features/mailbox_dashboard/presentation/extensions/get_mailbox_contain_extension.dart:6-15). If the message is opened from Favorites or another virtual folder,currentMailboxbecomes that presentation-only mailbox instead of the email’s actual team mailbox, so the trash lookup below falls back to personal Trash. Mirror the bulk-action virtual-folder guard here and resolve fromemail.findMailboxContain(...)in that case.🤖 Prompt for AI Agents