Skip to content

Comments

[#520] fix event order flicker#530

Merged
Eriikah merged 1 commit intomainfrom
520-display-glitch-when-opening-event
Feb 10, 2026
Merged

[#520] fix event order flicker#530
Eriikah merged 1 commit intomainfrom
520-display-glitch-when-opening-event

Conversation

@Eriikah
Copy link
Collaborator

@Eriikah Eriikah commented Feb 6, 2026

Related to #520

docker image on eriikaah/twake-calendar-front:issue-520-display-glitch-when-opening-event

Summary by CodeRabbit

  • Improvements
    • Refined personal calendar event identification methodology
    • Updated event editing restrictions to require organizer status
    • Streamlined priority flag logic for personal calendar events

@Eriikah Eriikah self-assigned this Feb 6, 2026
@Eriikah Eriikah linked an issue Feb 6, 2026 that may be closed by this pull request
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 6, 2026

Walkthrough

This pull request modifies the calendar utility functions to refactor event property computations. The isPersonalEvent flag is now determined solely by comparing the extracted calendar base UUID against the user ID, removing the organizer dependency. The editable flag has been restructured to require all three conditions: isPersonalEvent, isOrganiser, and not pending. The priority flag logic is simplified to return 1 whenever isPersonalEvent is true, independent of pending status.

Possibly related PRs

  • #519: Modifies the same calendarUtils.ts event property calculations with conflicting rules for organizer and pending checks
  • #413: Updates isPersonalEvent computation and sets the priority field for personal events in the same utility file

Suggested labels

merge_wanted

Suggested reviewers

  • chibenwa
  • lenhanphung
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title '[#520] fix event order flicker' directly matches the changes in the PR which modify event determination and ordering logic in calendarUtils.ts to prevent display glitches.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 520-display-glitch-when-opening-event

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Eriikah Eriikah force-pushed the 520-display-glitch-when-opening-event branch from fff1008 to 8433730 Compare February 10, 2026 10:12
Copy link
Member

@chibenwa chibenwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified: it is fixed

@Eriikah Eriikah merged commit 6b42597 into main Feb 10, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Display glitch when opening event

2 participants