TW-2881 Integrate CachedNetworkImage to MxcImage#2888
Open
tddang-linagora wants to merge 1 commit intomainfrom
Open
TW-2881 Integrate CachedNetworkImage to MxcImage#2888tddang-linagora wants to merge 1 commit intomainfrom
tddang-linagora wants to merge 1 commit intomainfrom
Conversation
tddang-linagora
requested review from
dab246,
hoangdat and
nqhhdev
as code owners
Contributor
|
This PR has been deployed to https://linagora.github.io/twake-on-matrix/2888 |
Member
Souds like an issue, no? |
Collaborator
Author
Yes that's why I don't even consider this solution when implement new cache system. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
Disclaimer
This PR only benefits the avatars and any image that use url as source. All images that are part of an matrix event will still blink on any part of the app's re-render.