[APRIL SPRINT] TW-2893 Add multi account noti#2909
[APRIL SPRINT] TW-2893 Add multi account noti#2909tddang-linagora wants to merge 4 commits intosprint/march26from
Conversation
tddang-linagora
requested review from
9clg6,
dab246,
hoangdat and
nqhhdev
as code owners
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This PR has been deployed to https://linagora.github.io/twake-on-matrix/2909 |
hoangdat
changed the title
| @@ -108,58 +109,201 @@ class BackgroundPush { | |||
| if (call.method == 'willPresent') { | |||
| onReceiveNotification(call.arguments); | |||
| } else if (call.method == 'didReceive') { | |||
There was a problem hiding this comment.
You should maybe create a enum for this
| @@ -108,58 +109,201 @@ class BackgroundPush { | |||
| if (call.method == 'willPresent') { | |||
There was a problem hiding this comment.
You should maybe create a enum for this
| currentPushers.first.appId == appId && | ||
| currentPushers.first.appDisplayName == clientName && | ||
| currentPushers.first.deviceDisplayName == targetClient.deviceName && | ||
| currentPushers.first.lang == 'en' && |
| appId: appId, | ||
| appDisplayName: clientName, | ||
| deviceDisplayName: targetClient.deviceName!, | ||
| lang: 'en', |
| } | ||
|
|
||
| void iOSUserSelectedNoti(dynamic noti) { | ||
| Future<void> iOSUserSelectedNoti(dynamic noti) async { |
There was a problem hiding this comment.
Noti should deserve a model class with @JsonAnnotation
| @@ -418,11 +599,19 @@ class BackgroundPush { | |||
| Future<void> onSelectNotification( | |||
tddang-linagora
force-pushed
the
TW-2893/ios-notification-option-2
branch
from
f52a704 to
4495678
Compare
2 participants
Ticket