Add a check for malformed manifest files #242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mtauraso
commented
Mar 20, 2025
mtauraso
commented
- When manifest or filter_catalog files contain filenames that are obviously for the wrong object ID, we will drop the relevant object and emit a warning
- Testing system extended to allow tests for malformed manifests to be written.
- Small fixup to .setup_dev.sh script to make sure that it's promise to "not output logs" unless there is an error is actually true.
mtauraso
force-pushed
the
hsc_malformed_manifest
branch
from
7d85104 to
2344e5f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #242 +/- ##
==========================================
+ Coverage 35.55% 36.04% +0.49%
==========================================
Files 33 33
Lines 2610 2627 +17
==========================================
+ Hits 928 947 +19
+ Misses 1682 1680 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mtauraso
force-pushed
the
hsc_malformed_manifest
branch
from
2344e5f to
2465eb0
Compare
drewoldag
approved these changes
Mar 24, 2025
Collaborator
drewoldag
left a comment
drewoldag
left a comment
There was a problem hiding this comment.
Looks good to me. Made a couple of small suggestions, nothing that should block moving ahead.
| echo "This might take a few minutes. Only errors will be printed to stdout" | ||
| python -m pip install -e .'[dev]' > /dev/null | ||
| if [ -f docs/requirements.txt ]; then python -m pip install -r docs/requirements.txt; fi | ||
| if [ -f docs/requirements.txt ]; then python -m pip install -r docs/requirements.txt > /dev/null; fi |
Collaborator
There was a problem hiding this comment.
If you haven't already, it would be worthwhile percolating this up to the Python Project Template.
Collaborator
Author
There was a problem hiding this comment.
mtauraso
force-pushed
the
hsc_malformed_manifest
branch
2 times, most recently
from
cae2913 to
ae52b7e
Compare
- When manifest or filter_catalog files contain filenames that are obviously for the wrong object ID, we will drop the relevant object and emit a warning - Testing system extended to allow tests for malformed manifests to be written. - Small fixup to .setup_dev.sh script to make sure that it's promise to "not output logs" unless there is an error is actually true.
mtauraso
force-pushed
the
hsc_malformed_manifest
branch
from
ae52b7e to
ce02439
Compare
aritraghsh09
pushed a commit
that referenced
this pull request
Apr 23, 2025
- When manifest or filter_catalog files contain filenames that are obviously for the wrong object ID, we will drop the relevant object and emit a warning - Testing system extended to allow tests for malformed manifests to be written. - Small fixup to .setup_dev.sh script to make sure that it's promise to "not output logs" unless there is an error is actually true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.