updated BaseOptions.format with explicit format types#286
Open
rscotten wants to merge 1 commit intolindell:masterfrom
rscotten:update-types-baseoptions-format
Open
updated BaseOptions.format with explicit format types#286rscotten wants to merge 1 commit intolindell:masterfrom rscotten:update-types-baseoptions-format
rscotten wants to merge 1 commit intolindell:masterfrom
rscotten:update-types-baseoptions-format
Conversation
Author
|
not sure why the first Travis build failed but the others passed 🤔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the Typscript typings for
BaseOptions.formatfromstringtotype Format = 'CODE39 | 'CODE128' | .... This will help us spell and case the formats correctly and give type-hinting from the IDE.