Skip to content

Delete unused code to generate code #1814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Yang-33 merged 2 commits into from
Jan 13, 2026
Merged

Delete unused code to generate code #1814

Yang-33 merged 2 commits into from
Jan 13, 2026

Conversation

@Yang-33
Copy link
Contributor

@Yang-33 Yang-33 commented Jan 13, 2026 •
edited
Loading

FileLoader is not used! ClasspathLoader resolved .*pebble, so it's ok to delete it.
Close #1800

@Yang-33 Yang-33 changed the title Delete unused code (pebble's FileLoader) Delete unused code to generate code Jan 13, 2026
@Yang-33 Yang-33 requested a review from a team January 13, 2026 07:58
@Yang-33 Yang-33 enabled auto-merge January 13, 2026 07:59
eucyt
eucyt approved these changes Jan 13, 2026
View reviewed changes
Copy link
Contributor

@eucyt eucyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Yang-33 Yang-33 added this pull request to the merge queue Jan 13, 2026
Merged via the queue into master with commit 42c8688 Jan 13, 2026
10 checks passed
@Yang-33 Yang-33 deleted the renovate/io.pebbletemplates-pebble-4.x-fix branch January 13, 2026 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eucyt eucyt eucyt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Yang-33 @eucyt