Skip to content

Conversation

@nottyo
Copy link

@nottyo nottyo commented Apr 25, 2025

To add FollowDetail object type to the FollowEvent type

Ref: https://developers.line.biz/en/reference/messaging-api/#follow-event

@CLAassistant
Copy link

CLAassistant commented Apr 25, 2025

CLA assistant check
All committers have signed the CLA.

@Yang-33
Copy link
Contributor

Yang-33 commented Apr 28, 2025

how about using

?

@nottyo
Copy link
Author

nottyo commented Apr 28, 2025

Yeah, it's usable but the type defined in the lib/types still not up to date. Mostly people reference the type definition from this file, so should we update it as well ?

I mean we usually import the type like this

import { FollowEvent } from '@line/bot-sdk';

which is not up to date yet.

rather than

import { FollowEvent } from '@line/bot-sdk/dist/webhook/api';

@Yang-33
Copy link
Contributor

Yang-33 commented May 8, 2025

Sorry for late review.
The way to deprecate in the code is incorrect,(

/**
* @deprecated Use types generated by openapi spec instead.
*/
) but as announced here, the current code (lib/types.ts) is no longer maintained and will be removed soon.

It is recommended to use the new code.

Can you migrate to the new code? On the other hand, if you need this immediately, we can merge this and release by increasing the patch version. (though we don't maintain old code)

@nottyo
Copy link
Author

nottyo commented May 8, 2025

Got it. I think I'll update my dep to use the newer version. Thanks. So this PR will be closed.

@nottyo nottyo closed this May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants