-
Notifications
You must be signed in to change notification settings - Fork 426
Drop Node.js 18 support #1302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Node.js 18 support #1302
Conversation
| id: setup_node_id | ||
| with: | ||
| node-version: 18 | ||
| node-version: 24 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've confrimed npm run apidocs and npm run docs:build by Node.js 24
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are already tested.
line-bot-sdk-nodejs/.github/workflows/test.yml
Lines 41 to 55 in ee85d1a
| - name: Generate code | |
| run: | | |
| python3 generate-code.py | |
| - name: Test Project | |
| run: export NODE_OPTIONS=--max-old-space-size=6144; npm test | |
| - name: Test building apidocs | |
| run: export NODE_OPTIONS=--openssl-legacy-provider; npm run apidocs | |
| - name: Test building docs | |
| run: export NODE_OPTIONS=--openssl-legacy-provider; npm run docs:build | |
| - name: Test building examples (CJS) | |
| run: | | |
| cd examples/echo-bot-ts-cjs | |
| npm run build-sdk | |
| npm install | |
| npm run build |
| - uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0 | ||
| with: | ||
| node-version: 18 | ||
| node-version: 24 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've confirmed npx zx ./line-openapi/tools/determine-change-type.mjs and npx zx ./line-openapi/tools/get-pr-info.mjs by Node.js 24
| - uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0 | ||
| with: | ||
| node-version: 18 | ||
| node-version: 24 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Acutually, we can not test this CI but maybe OK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can test node ./scripts/update-version.mjs $VERSION
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've confrimed 🙏
Yang-33
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Resolved #1259
TODO