Skip to content

Conversation

@eucyt
Copy link
Contributor

@eucyt eucyt commented Jun 2, 2025

Resolved #1259

TODO

  • Remove CI by Node.js 18 from Status checks that are required.

id: setup_node_id
with:
node-version: 18
node-version: 24
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've confrimed npm run apidocs and npm run docs:build by Node.js 24

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are already tested.

- name: Generate code
run: |
python3 generate-code.py
- name: Test Project
run: export NODE_OPTIONS=--max-old-space-size=6144; npm test
- name: Test building apidocs
run: export NODE_OPTIONS=--openssl-legacy-provider; npm run apidocs
- name: Test building docs
run: export NODE_OPTIONS=--openssl-legacy-provider; npm run docs:build
- name: Test building examples (CJS)
run: |
cd examples/echo-bot-ts-cjs
npm run build-sdk
npm install
npm run build

- uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
with:
node-version: 18
node-version: 24
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've confirmed npx zx ./line-openapi/tools/determine-change-type.mjs and npx zx ./line-openapi/tools/get-pr-info.mjs by Node.js 24

- uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
with:
node-version: 18
node-version: 24
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acutually, we can not test this CI but maybe OK.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can test node ./scripts/update-version.mjs $VERSION

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've confrimed 🙏

@eucyt eucyt self-assigned this Jun 2, 2025
@eucyt eucyt requested a review from a team June 2, 2025 04:15
Copy link
Contributor

@Yang-33 Yang-33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@eucyt eucyt added this pull request to the merge queue Jun 2, 2025
Merged via the queue into line:master with commit 57c6dd5 Jun 2, 2025
7 checks passed
@eucyt eucyt deleted the feature/drop-nodejs-18 branch June 2, 2025 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop Node.js 18 support

2 participants