-
Notifications
You must be signed in to change notification settings - Fork 426
Reminder for npm audit fix #1357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
blockers to merge this change(no blocker for review) |
eucyt
approved these changes
Aug 5, 2025
Contributor
eucyt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 🙇
Contributor
Author
|
This change will be merged after #1392 is merged |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 18, 2025
## Changes This change resolves all npm audit issues as of now. Even with #1357, this change won't report issue. ESBuild dependency(though we don't use...) is forcibly upgraded to avoid secrutiy issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most npm package alerts can be fixed automatically with
npm audit fix --force(it is not perfect, so some manual work is still required).Because we cannot use a GitHub App token, a reminder should be enough. Automatically creating PRs would be pointless, because the CI jobs will not run, and it may be old(=merging may not resolve all issues)
For now, let's create a reminder as an issue. We review issues regularly, so this should be sufficient.