Allow to skip signature verification #1398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yang-33
reviewed
Sep 19, 2025
lib/middleware.ts
Outdated
| })(); | ||
|
|
||
| if (!validateSignature(body, secret, signature)) { | ||
| // Check if signature verification should be skipped |
Contributor
There was a problem hiding this comment.
variable name represents this enough, so inline comment seems unnecessary!
| listen(TEST_PORT, m); | ||
| }); | ||
|
|
||
| describe("With skipSignatureVerification functionality", () => { |
Contributor
There was a problem hiding this comment.
Aren't these tests run in parallel?
To avoid flaky tests, can we design the tests so they don't share state?
Contributor
There was a problem hiding this comment.
I thought it would be fine just to have something like mWithDynamicSkip or others within the test. Each test should be able to define its own before~ and after~.
Yang-33
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Motivation
The signature returned with webhooks is calculated using a single channel secret. If the bot owner changes their channel secret, the signature for webhooks starts being calculated using the new channel secret. To avoid signature verification failures, the bot owner must update the channel secret on their server, which is used for signature verification. However, if there is a timing mismatch in the update—and such a mismatch is almost unavoidable—verification will fail during that period.
In such cases, having an option to skip signature verification for webhooks would be a convenient way to avoid these issues.