Skip to content

Use github actor id instead of bot name to avoid renaming issues #1399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 19, 2025
Merged

Use github actor id instead of bot name to avoid renaming issues #1399

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc2287b
NO-ISSUE Use github actor id instead of bot name to avoid renaming is…
Yang-33 Sep 18, 2025
bc6f87e
NO-ISSUE to string
Yang-33 Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/generate-code.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,12 @@ jobs:
echo "DIFF_IS_EMPTY=$([[ -z "$diff_excluding_submodule" ]] && echo 'true' || echo 'false')" >> $GITHUB_ENV
echo "CURRENT_DATETIME=$(date +'%Y%m%d%H%M%S')" >> $GITHUB_ENV
## Run if diff exists and pull request or merge queue, and make CI status failure (but allow renovate bot)
## 29139614 is renovate bot's actor id
- if: >-
${{
(github.event_name == 'pull_request' || github.event_name == 'merge_group')
&& env.DIFF_IS_EMPTY != 'true'
&& github.actor != 'renovate[bot]'
&& github.actor_id != '29139614'
Copy link
Contributor Author

@Yang-33 Yang-33 Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.github.com/en/actions/reference/workflows-and-actions/contexts#github-context

github.actor_id string The account ID of the person or app that triggered the initial workflow run. For example, 1234567. Note that this is different from the actor username.

though API returns integer, github actions context returns string probably.

}}
run: |
echo "There are changes in the generated codes. Please run 'generate-code.py' and commit the changes." >&2
Expand Down