Skip to content

Prevent command injection when creating release notes #866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 15, 2025
Merged

Prevent command injection when creating release notes #866

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c8f158
NO-ISSUE Prevent command injection when creating release notes
Yang-33 Oct 10, 2025
6a13148
Merge branch 'master' into prevend-injection
Yang-33 Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions .github/workflows/create-draft-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,8 @@ jobs:
.concat(`\n\n${footer}`);

console.log(`releaseNotes (modified): ${JSON.stringify(modifiedBody, null, 2)}`);
core.setOutput("release_body", modifiedBody);
const fs = require('fs');
fs.writeFileSync('release-notes.txt', modifiedBody, { encoding: 'utf8' });

- name: Prepare Release Title
id: title
Expand All @@ -118,10 +119,6 @@ jobs:
SANITIZED_TITLE="$(printf '%s' "$RAW_TITLE" | sed 's/"/\\"/g')"
echo "sanitized_title=$SANITIZED_TITLE" >> "$GITHUB_OUTPUT"

- name: Write Release Notes to File
run: |
echo "${{ steps.generate-release-notes.outputs.release_body }}" > release-notes.txt

- name: Create Draft Release
run: |
gh release create "${{ steps.calculate-version.outputs.new_version }}" \
Expand Down