Fix request content in messaging test #457
Conversation
| request = { | ||
| "to" => "USER_ID", | ||
| "messages" => [{ type: 'text', text: ' Hello, world! ' }] | ||
| } |
There was a problem hiding this comment.
this (without using Line::Bot::V2::MessagingApi::PushMessageRequest) is acceptable as of now.
Q: I'm not sure if it's intentional. Is this intentional? @mokuzon
There was a problem hiding this comment.
It is not my intention to do so, but I do get a warning from RBS.
Since we do not strictly implement type checking, I think this is an unavoidable behavior.
There was a problem hiding this comment.
Thank you for the reply. Since it wasn't intentional, let's remove the current behavior from the spec (i.e., don't explicitly mention it in the documentation, but leave the code as is). On the other hand, I thought that v1 users might appreciate this behavior when migrating to v2, as it makes the migration process much simpler. There's no need to actively rewrite the request object.
If, in the future, this behavior becomes problematic for any SDK users, we can discontinue the current behavior.
2 participants
The structure itself was completely wrong...
This change modifies tests to use both the hash and the SDK class, and also to verify the body using WebMock.