Skip to content

fix: Update lang attribute to 'ko' #1682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dkstyle merged 1 commit into from
Mar 1, 2025
Merged

fix: Update lang attribute to 'ko' #1682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cypress/e2e/check-server-side-rendering.cy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ describe('server side rendered page', () => {

it('should find html tag with lang', () => {
cy.visit('/');
cy.get('html[lang="en"]');
cy.get('html[lang="ko"]');
});

it('should find meta charset', () => {
Expand Down
2 changes: 1 addition & 1 deletion examples/module-federation/app1/public/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<!DOCTYPE html>
<html lang="en">
<html lang="ko">
<head>
<meta charset="UTF-8">
<title>App 1</title>
Expand Down
2 changes: 1 addition & 1 deletion examples/module-federation/app2/public/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<!DOCTYPE html>
<html lang="en">
<html lang="ko">
<head>
<meta charset="UTF-8">
<title>App 2</title>
Expand Down
2 changes: 1 addition & 1 deletion src/components/Site/Site.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ function Site(props) {
return (
<div className="site">
<Helmet>
<html lang="en" />
<html lang="ko" />
<meta charset="utf-8" />
<meta name="theme-color" content="#2B3A42" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
Expand Down
13 changes: 6 additions & 7 deletions src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
<!DOCTYPE html>
<html lang="en">
<head>
</head>
<body>
<div id="root"></div>
</body>
<!doctype html>
<html lang="ko">
<head> </head>
<body>
<div id="root"></div>
</body>
</html>
Loading