Bake composite properties data #473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertbastian
force-pushed
the
bake-composite
branch
from
3117d88 to
125f3b4
Compare
robertbastian
force-pushed
the
bake-composite
branch
from
d32cc74 to
093d31e
Compare
taj-p
approved these changes
Dec 3, 2025
Contributor
taj-p
left a comment
taj-p
left a comment
There was a problem hiding this comment.
THANK YOU! TIL. This is much better. Appreciate it 🙏
You might be interested in this conversation (taj-p#4 (comment)) we had with Behdad about using PackTab (what HarfBuzz/HarfRust use to pack unicode data) as a future replacement of CodePointTrie.
Contributor
Author
|
Yes you should use PackTab if you can get better performance out of that. For ICU4X in general that's more complicated, because all PackTab results would need to be the same Rust type (which is not a requirement for your singleton). We could experiment with baking function pointers as part of the data, which might optimize as well. |
conor-93
added a commit
to conor-93/parley
that referenced
this pull request
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need for ICU4X's data provider infrastructure, we can directly bake the
CodePointTrie<u32>and access that. This gets around the limitation of not being able to bake custom data markers, and removes the serde serialization.#452