Update to ui-events and ui-events-winit 0.2.0.#1103
Conversation
|
Can you rebase this forward? |
DJMcNab
left a comment
DJMcNab
left a comment
There was a problem hiding this comment.
Mostly looks good (once this is released)
| delta: ScrollDelta::PixelDelta(PhysicalPosition::<f64> { x: 0., y: 25. }), | ||
| state: PointerState::default(), | ||
| }); | ||
| harness.mouse_wheel(Vec2 { x: 0., y: 25. }); |
|
Would like a yes/no on the destructuring-based version (second commit) vs the opaque version (first commit), as we're about to do an ui-events-0.2.0 so we need to choose one. :+ ) |
|
@DJMcNab That's a plea for you to comment on that. :) |
|
Destructuring is fine by me. It's certainly better than extremely short names. |
xorgy
force-pushed
the
ui-events-0.2.0
branch
2 times, most recently
from
a632a69 to
5f27425
Compare
xorgy
force-pushed
the
ui-events-0.2.0
branch
from
5f27425 to
9705e2d
Compare
|
Alright, we've now published |
waywardmonkeys
left a comment
waywardmonkeys
left a comment
There was a problem hiding this comment.
Would still like to get feedback from @DJMcNab on this.
DJMcNab
left a comment
DJMcNab
left a comment
There was a problem hiding this comment.
Other than the blocking rebase artifact, this looks good. I do have a couple of other thoughts, but nothing too significant.
Thanks!
xorgy
force-pushed
the
ui-events-0.2.0
branch
from
9705e2d to
f272f80
Compare
See discussion in [#xilem > v0.4.0](https://xi.zulipchat.com/#narrow/channel/354396-xilem/topic/v0.2E4.2E0/with/547457987). Target date is tomorrow to just let everything settle (e.g. #1103). https://linebender.org/wiki/process/release/#checklist I have run a publish dry run, using the command: ```sh cargo publish --dry-run -p xilem -p xilem_core -p masonry -p masonry_core -p masonry_winit -p masonry_testing -p tree_arena -p xilem_web ``` We don't have a changelog (yet, plan is to start immediately after this releasee), we have bumped dependencies (pending #1103).
3 participants
No description provided.