Open
Conversation
Validate scenes by in debug mode in paint pass. Add some "assert_debug_panics" type tests for scene validation.
Contributor
jaredoconnell
left a comment
jaredoconnell
left a comment
There was a problem hiding this comment.
It makes sense to add this to catch errors. But what is the plan for once sparse strips is added? It would be unfortunate to add this, then remove it later. I see that as a sign that maybe the logic for this should be elsewhere, like in Vello.
Contributor
Author
|
I'm lobbying for it to be added to sparse strips as well: |
Contributor
Author
|
AFAICT the consensus during last Office Hours was that this is fine for now as a stopgap. @DJMcNab any objection to merging this now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate scenes in debug mode in paint pass.
Add some "assert_debug_panics" type tests for scene validation.