Remove SharedLocalKubernetesNetTestingConfig #3000
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 3, 2024
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Dec 3, 2024
ndr-ds
force-pushed
the
12-03-run_existing-net-test_in_a_kubernetes_local_network
branch
from
e31498b to
e582750
Compare
ndr-ds
force-pushed
the
12-03-remove_sharedlocalkubernetesnettestingconfig
branch
from
7148d5f to
62e263f
Compare
ndr-ds
force-pushed
the
12-03-run_existing-net-test_in_a_kubernetes_local_network
branch
from
e582750 to
aa60798
Compare
ndr-ds
force-pushed
the
12-03-remove_sharedlocalkubernetesnettestingconfig
branch
from
62e263f to
74ccbaa
Compare
ndr-ds
force-pushed
the
12-03-run_existing-net-test_in_a_kubernetes_local_network
branch
from
aa60798 to
dad147a
Compare
ndr-ds
force-pushed
the
12-03-run_existing-net-test_in_a_kubernetes_local_network
branch
from
dad147a to
8317398
Compare
ndr-ds
force-pushed
the
12-03-remove_sharedlocalkubernetesnettestingconfig
branch
from
74ccbaa to
6fe0379
Compare
Contributor
Author
|
This is back to being used now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Now that we can run tests against an existing network (that can be a kubernetes local network), this doesn't seem necessary anymore.
Proposal
Remove it
Test Plan
CI
Release Plan