Add Wasm-compatible adapters for implementing Signer trait that work in web browser. Add sample integrations. #4017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twey
reviewed
May 27, 2025
Twey
reviewed
May 27, 2025
deuszx
force-pushed
the
web-signer-fn
branch
6 times, most recently
from
4ec9304 to
8c367a5
Compare
deuszx
changed the title
Twey
reviewed
Jun 4, 2025
Twey
reviewed
Jun 4, 2025
Twey
reviewed
Jun 4, 2025
Twey
reviewed
Jun 4, 2025
Twey
reviewed
Jun 4, 2025
Twey
reviewed
Jun 4, 2025
Twey
reviewed
Jun 4, 2025
Twey
reviewed
Jun 4, 2025
Twey
reviewed
Jun 4, 2025
Twey
reviewed
Jun 4, 2025
Twey
reviewed
Jun 4, 2025
Twey
reviewed
Jun 4, 2025
Twey
reviewed
Jun 4, 2025
Twey
reviewed
Jun 4, 2025
Twey
reviewed
Jun 4, 2025
They will have different lifecycles.
The root cause for problems here was serializing CryptoHash using wasm_bindgen and serde. We can't serialize, because that adds new bytes which are not present when verifying the signature. We are working with the bytes - that CryptoHash wraps - directly. JsValue was a wrong type to use as well. Now we use UInt8Array as that affects the logic inside the ethers' signMessage method. To summarize: CryptoHash had to be passed in as raw bytes it wraps.
deuszx
force-pushed
the
web-signer-fn
branch
3 times, most recently
from
13f6432 to
085ed8a
Compare
What's left is extracting JS Signer interface to a separate file and include_str! it and extracting the MetaMask implementation to a separate PR.
Twey
reviewed
Jun 5, 2025
Twey
approved these changes
Jun 6, 2025
Contributor
Twey
left a comment
Twey
left a comment
There was a problem hiding this comment.
Looks good to me. Great work!
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to be able to sign block proposals using EVM-compatible wallets in the web browser.
Proposal
Add
linera-web/signerdirectory with sample implementations ofSignertrait for in-memory private key (in_memory.ts) and MetaMask integration (metamask.ts).Pre-existing
Walletimplementations inlinera-webwas adapted to work with the new abstractions.Test Plan
CI/Manual testing.
Release Plan