Some code cleanups #4066
Merged
Some code cleanups #4066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 4, 2025
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ndr-ds
force-pushed
the
06-04-some_code_cleanups
branch
from
0ff7949 to
2bd4ab3
Compare
ndr-ds
force-pushed
the
06-04-some_code_cleanups
branch
8 times, most recently
from
3adb3a8 to
b72852f
Compare
ndr-ds
requested review from
MathieuDutSik,
Twey,
afck,
bart-linera,
deuszx and
ma2bd
ma2bd
reviewed
Jun 5, 2025
| @@ -1,70 +1,52 @@ | |||
| // Copyright (c) Zefchain Labs, Inc. | |||
Contributor
There was a problem hiding this comment.
I'd love to push this code to tests only but I suppose it's not easy.
ma2bd
approved these changes
Jun 5, 2025
ndr-ds
changed the base branch from
06-02-optimize_scylladb_s_batch_writes
to
graphite-base/4066
ndr-ds
force-pushed
the
graphite-base/4066
branch
from
b6a6083 to
04f4740
Compare
ndr-ds
force-pushed
the
06-04-some_code_cleanups
branch
from
b72852f to
877abcb
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Found some small code cleanups to do while working on the ScyllaDb code
Proposal
Clean up the code a bit
Test Plan
CI
Release Plan