Properly wait for things that are spawned as bg processes #4408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ndr-ds
force-pushed
the
08-25-properly_wait_for_things_that_are_spawned_as_bg_processes
branch
12 times, most recently
from
be834c0 to
fc6eb89
Compare
ndr-ds
force-pushed
the
08-25-properly_wait_for_things_that_are_spawned_as_bg_processes
branch
from
fc6eb89 to
e138c97
Compare
deuszx
approved these changes
Aug 26, 2025
Contributor
deuszx
left a comment
deuszx
left a comment
There was a problem hiding this comment.
Nice <3
Gonna merge it right away
deuszx
deleted the
08-25-properly_wait_for_things_that_are_spawned_as_bg_processes
branch
ma2bd
pushed a commit
to ma2bd/linera-protocol
that referenced
this pull request
Sep 23, 2025
…4408) ## Motivation Right now we have a lot of stuff in CI that gets started as a bg process. However, the issue is that if these things start taking slightly longer to start up for some reason, it'll make the test fail, because the test will try to submig requests to something that isn't ready yet. ## Proposal Explicitly wait for things to be actually up before proceeding. ## Test Plan CI ## Release Plan - Nothing to do / These changes follow the usual release cycle.
ma2bd
added a commit
that referenced
this pull request
Sep 23, 2025
## Motivation Solve the issue of the forgetful faucet ## Proposal backport #4408 and #4631 ## Test Plan CI --------- Co-authored-by: Andre da Silva <[email protected]> Co-authored-by: Andreas Fackler <[email protected]>
ma2bd
added a commit
that referenced
this pull request
Sep 23, 2025
## Motivation Solve the issue of the forgetful faucet ## Proposal backport #4408 and #4631 ## Test Plan CI --------- Co-authored-by: Andre da Silva <[email protected]> Co-authored-by: Andreas Fackler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Right now we have a lot of stuff in CI that gets started as a bg process. However, the issue is that if these things start taking slightly longer to start up for some reason, it'll make the test fail, because the test will try to submig requests to something that isn't ready yet.
Proposal
Explicitly wait for things to be actually up before proceeding.
Test Plan
CI
Release Plan