Don't set base timeout to u64::MAX on test_end_to_end_listen_for_new_rounds #4495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ma2bd
approved these changes
Sep 5, 2025
afck
requested changes
Sep 6, 2025
Contributor
There was a problem hiding this comment.
In this scenario there should never be a round timeout, that's the point of this test: both chain owners are live, so one of them should always immediately propose a block.
This test used to work reliably. We need to find the commit that broke it.
(Edit: To clarify, clients will in some cases conclude that they have to wait for the timeout, but their wait will always very quickly be interrupted by a notification due to the other client's actions.)
Contributor
Author
|
Fix for the notifications is this: #4516 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We're setting the base timeout for the chain we're opening to
u64::MAX. However, since this test is racey by design, if we happen to get aRoundTimeoutin proposals in both of the chains, we'll effectively wait forever and the test will never return.Proposal
Set the base timeout to something more reasonable. Setting to 10 seconds, as it's what the rest of the file is using.
Test Plan
Had a consistent repro of this happening and the test hanging forever. After this change, the test passes.
Release Plan