-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Implement a function has_empty_storage in BaseRuntime.
#4530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MathieuDutSik
wants to merge
11
commits into
linera-io:main
Choose a base branch
from
MathieuDutSik:has_non_trivial_storage
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Implement a function has_empty_storage in BaseRuntime.
#4530
MathieuDutSik
wants to merge
11
commits into
linera-io:main
from
MathieuDutSik:has_non_trivial_storage
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2c0b666 to
c836461
Compare
has_non_trivial_storage in BaseRuntime.has_trivial_storage in BaseRuntime.
e7893a5 to
34c8d40
Compare
34c8d40 to
04872d0
Compare
deuszx
reviewed
Nov 6, 2025
deuszx
reviewed
Nov 6, 2025
has_trivial_storage in BaseRuntime.has_empty_storage in BaseRuntime.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
For the purpose of testing if a contract exists in EVM, we introduce the functionality of testing if a contract
has empty storage.
Proposal
The following is done:
BaseRuntime.TotalStorageSizein theexecution_state_actor.rs.view.total_size()of theKeyValueStoreView.Several points have to be noted:
self.state.save().awaitdoes their state become observable. This point is exemplified in the example test.fn finalizestep, then we cannot see that its state is non-trivial only at the next block.fn finalize. So, that is fine here.Test Plan
The CI.
For testing the
has_empty_storage, we implemented separately some end-to-end tests.They have not been put in the PR, since you need two contracts:
has_empty_storage.Release Plan
This does not appear to be TestNet breaking.
Links
The test is implemented in test_has_empty_state