Skip to content

Conversation

@ma2bd
Copy link
Contributor

@ma2bd ma2bd commented Sep 15, 2025

Motivation

Allow using --with-wallet NAME without setting 3 environment variables first!

Proposal

  • Introduce a notion of home directory (e.g. set to a temporary directory for testing)
  • Maintain backward compatibility

Test Plan

CI

Release Plan

This first PR is meant to be backward compatibly so that it can be backported on testnet_conway

@ma2bd ma2bd changed the base branch from main to testnet_conway September 15, 2025 01:54
@ma2bd ma2bd changed the title [testnet] support wallet home directory support wallet home directory Sep 15, 2025
@ma2bd ma2bd changed the base branch from testnet_conway to main September 15, 2025 01:56
@ma2bd ma2bd marked this pull request as ready for review September 15, 2025 02:31
@ma2bd ma2bd requested review from Twey and deuszx September 15, 2025 02:31
@ma2bd ma2bd marked this pull request as draft September 15, 2025 02:34
@Twey
Copy link
Contributor

Twey commented Sep 15, 2025

Instead of a home directory could we have --with-wallet just take a directory path?

Otherwise we probably want a full suite of commands to do management — create, list, update, delete available wallets. But I'd much rather we just use a directory with a normal directory path, and the user can manage wallets with their normal filesystem tools.

@ma2bd ma2bd marked this pull request as ready for review October 5, 2025 23:15
@ma2bd ma2bd marked this pull request as draft October 5, 2025 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants