Skip to content

Forbid anonymous enum variants in GraphQLMutationRoot. #4657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Forbid anonymous enum variants in GraphQLMutationRoot. #4657

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39e47ac
Forbid the use of "field0" entries.
MathieuDutSik Sep 24, 2025
b2aff47
Correction from clippy.
MathieuDutSik Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 19 additions & 27 deletions linera-sdk-derive/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,26 +57,12 @@ fn generate_mutation_root_code(input: ItemEnum, crate_root: &str) -> TokenStream
}
});
}
Fields::Unnamed(unnamed) => {
let mut fields = vec![];
let mut field_names = vec![];
for (i, field) in unnamed.unnamed.iter().enumerate() {
let name = concat(&syn::parse_str::<Ident>("field").unwrap(), &i.to_string());
let ty = &field.ty;
fields.push(quote! {#name: #ty});
field_names.push(name);
}
methods.push(quote! {
async fn #function_name(&self, #(#fields,)*) -> [u8; 0] {
let operation = #enum_name::#variant_name(
#(#field_names,)*
);

self.runtime.schedule_operation(&operation);

[]
}
});
Fields::Unnamed(_) => {
return syn::Error::new_spanned(
variant_name,
"Unnamed fields are not supported in GraphQL mutation root derivation",
)
.to_compile_error();
}
Fields::Unit => {
methods.push(quote! {
Expand Down Expand Up @@ -147,7 +133,6 @@ pub mod tests {
fn test_derive_mutation_root() {
let operation: ItemEnum = parse_quote! {
enum SomeOperation {
TupleVariant(String),
StructVariant {
a: u32,
b: u64
Expand All @@ -174,12 +159,6 @@ pub mod tests {
Application: linera_sdk::Service,
linera_sdk::ServiceRuntime<Application>: Send + Sync,
{
async fn tuple_variant(&self, field0: String,) -> [u8; 0] {
let operation = SomeOperation::TupleVariant(field0,);
self.runtime.schedule_operation(&operation);
[]
}

async fn struct_variant(&self, a: u32, b: u64,) -> [u8; 0] {
let operation = SomeOperation::StructVariant { a, b, };
self.runtime.schedule_operation(&operation);
Expand Down Expand Up @@ -211,4 +190,17 @@ pub mod tests {

assert_eq_no_whitespace(output.to_string(), expected.to_string());
}

#[test]
fn test_derive_mutation_root_rejects_unnamed_fields() {
let operation: ItemEnum = parse_quote! {
enum SomeOperation {
TupleVariant(String),
}
};

let output = generate_mutation_root_code(operation, "linera_sdk");
let output_str = output.to_string();
assert!(output_str.contains("Unnamed fields are not supported"));
}
}
Loading