Make sure that the Scylla config ConfigMap exists when Scylla gets created #4871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Oct 29, 2025
Base automatically changed from
10-28-fix_small_bug_on_exporter_config
to
main
October 29, 2025 04:56
ndr-ds
deleted the
10-23-make_sure_that_the_scylla_config_configmap_exists_when_scylla_gets_created
branch
ndr-ds
added a commit
that referenced
this pull request
Oct 30, 2025
…eated (#4871) ## Motivation We're setting Scylla settings using this ConfigMap, but there's actually no guarantee that it will exist by the time Scylla starts. I've seen networks deployed that just ignore the ConfigMap and use default settings, for example, because the ConfigMap wasn't created yet when Scylla started. ## Proposal Enforce that the ConfigMap will be created before Scylla starts. ## Test Plan Deployed a network, it uses the ConfigMap options more reliably now ## Release Plan - These changes should be backported to the latest `testnet` branch, then - be released in a validator hotfix.
ndr-ds
added a commit
that referenced
this pull request
Oct 30, 2025
…eated (#4871) ## Motivation We're setting Scylla settings using this ConfigMap, but there's actually no guarantee that it will exist by the time Scylla starts. I've seen networks deployed that just ignore the ConfigMap and use default settings, for example, because the ConfigMap wasn't created yet when Scylla started. ## Proposal Enforce that the ConfigMap will be created before Scylla starts. ## Test Plan Deployed a network, it uses the ConfigMap options more reliably now ## Release Plan - These changes should be backported to the latest `testnet` branch, then - be released in a validator hotfix.
ndr-ds
added a commit
that referenced
this pull request
Oct 30, 2025
## Motivation Backport a few PRs: - **Make sending traces to Tempo less confusing (#4771)** - **Add otlp_exporter_endpoint option to proxy/server as well (#4829)** - **Stop using init and entrypoint scripts (#4830)** - **Use release_max_level_trace instead (#4554)** - **Make all heap profile logs trace (#4845)** - **exporter: Add retry logging to indexer connection (#4846)** - **Fix notification forwarding to avoid duplicate messages and handle lag (#4848)** - **Fix a few explorer frontend bugs (#4849)** - **Add support for exporter/indexer/explorer stack deployment (#4850)** - **Stop getting service monitor CRD from GitHub (#4855)** - **Fix small bug on exporter config (#4870)** - **Make sure that the Scylla config ConfigMap exists when Scylla gets created (#4871)** - **Remove UNIQUE constraints – those should be tracked by the node anyway (#4852)** ## Proposal Backport ## Test Plan CI --------- Co-authored-by: deuszx <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We're setting Scylla settings using this ConfigMap, but there's actually no guarantee that it will exist by the time Scylla starts. I've seen networks deployed that just ignore the ConfigMap and use default settings, for example, because the ConfigMap wasn't created yet when Scylla started.
Proposal
Enforce that the ConfigMap will be created before Scylla starts.
Test Plan
Deployed a network, it uses the ConfigMap options more reliably now
Release Plan
testnetbranch, then