linera_base::tracing: move into linera-service and linera-web respectively
#4898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twey
force-pushed
the
split-tracing
branch
3 times, most recently
from
ac3e227 to
ea5d957
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently we have one
tracingentrypoint inlinera-baseto be split between our various tracing implementations. This entrypoint has a different implementation for each of our three supported platforms (unix,web, and Linera), which makes the conditional compilation quite complicated.Proposal
Instead, move the two present implementations onto target-specific codepaths (native to
linera-service, which currently functions as a catch-all crate for all our Linera UNIX binaries, and Web tolinera-web).linera-summarynow doesn't use this, but doesn't really need to (it's a CI tool). It would be nice in the future to split out CLI utilities like input/output formats fromlinera-serviceinto a crate that can be reüsed, and splitlinera-serviceinto different crates that depend on that.Test Plan
CI. The existing test has been ported to the new structure.
Release Plan
Links