Revert #4642; show "admin"/"default" in wallet show.
#4907
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2502447.
afck
requested review from
MathieuDutSik,
Twey,
bart-linera,
deuszx,
eldios,
ma2bd and
ndr-ds
Contributor
|
How about this: no columns (maybe just separating lines |
Contributor
Author
|
Closing in favor of #4927. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#4642 was controversial, but we want to make it easy to see in
wallet showwhich one is the admin chain.Proposal
Print "admin" and/or "default" in the chain ID cell in
wallet show(implemented by Claude):Test Plan
I tried it locally. (See screenshot.)
Release Plan
testnet_conway, thenLinks
wallet show. #4642.