Clean up event subscribers when stopping to listen to a chain#5514
Merged
bart-linera merged 1 commit intolinera-io:mainfrom Feb 25, 2026
Merged
Clean up event subscribers when stopping to listen to a chain#5514bart-linera merged 1 commit intolinera-io:mainfrom
bart-linera merged 1 commit intolinera-io:mainfrom
Conversation
afck
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#5506 revealed a bug in the
ChainListener, which is not exposed by the existing tests onmaindue to different handling of event subscriptions. The bug is that when theChainListenerstops listening to a chain, it doesn't remove it from theevent_subscriptionsmap.Proposal
Always remove a chain from
event_subscriptionswhen no longer listening to it.Test Plan
CI will catch regressions.
Release Plan
Links