Align DistSQL handler package layout in kernel/distsql by Copilot · Pull Request #6 · linghengqian/shardingsphere

Copilot · 2026-01-27T11:53:39Z

Relocates the migrated DistSQL executors into the finalized package layout for the new kernel/distsql module, matching the original proxy ral and rul namespaces.

Changes Made

Package layout: Move RAL queryable/updatable handlers under org.apache.shardingsphere.distsql.handler.ral.* and RUL handlers under org.apache.shardingsphere.distsql.handler.rul.*.
Source/test updates: Adjust package declarations, imports, and test locations to match the new namespaces.
SPI + reachability: Update SPI registration entries and native-image reachability metadata to the new package names.

Original prompt

The link apache#37778 (review) mentions that most DistSQL executors are located under proxy/backend/handler/distsql. Please migrate as many distsql-related modules as possible to the Maven submodules of https://github.com/apache/shardingsphere/tree/master/kernel to serve the usage of apache#37778 . This mainly involves org.apache.shardingsphere.distsql.**, org.apache.shardingsphere.proxy.backend.distsql.**, or other Java packages.

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: linghengqian <20187731+linghengqian@users.noreply.github.com>

Copilot · 2026-01-28T03:07:57Z

I encountered errors locally when running ./mvnw clean install -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e and ./mvnw checkstyle:check -Pcheck -T1C using OpenJDK 24.0.2. You need to fix your ...

Fixed the migrated unit tests, updated reachability metadata, and ran Spotless, scoped tests, and Checkstyle. Latest commit: 4e113c4.

Co-authored-by: linghengqian <20187731+linghengqian@users.noreply.github.com>

Copilot · 2026-01-28T04:07:42Z

I think you need to migrate or add SetDistVariableExecutorTest, RefreshDatabaseMetaDataExecutorTest, and DistSQLUpdateProxyBackendHandlerTest at the same time, regardless of which Maven module t...

Restored SetDistVariableExecutorTest, RefreshDatabaseMetaDataExecutorTest, and DistSQLUpdateProxyBackendHandlerTest in commit b48d4f8.

linghengqian

confirm.

Co-authored-by: linghengqian <20187731+linghengqian@users.noreply.github.com>

Copilot · 2026-01-28T04:53:03Z

confirm.

Completed the package realignment to handler/ral/queryable, handler/ral/updatable, and handler/rul (sources, tests, SPI, reachability metadata). Commit: 1ea8e20.

Copilot

Pull request overview

This PR migrates DistSQL handler executors from the proxy/backend/handler/distsql package to a new kernel/distsql/handler module, aligning with the final package structure for the ShardingSphere kernel architecture.

Changes:

Created new Maven module structure (kernel/distsql and kernel/distsql/handler)
Migrated RAL queryable/updatable and RUL handlers to new package namespace
Updated SPI registrations and native-image reachability metadata

Reviewed changes

Copilot reviewed 40 out of 40 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
kernel/pom.xml	Added distsql submodule to kernel parent
kernel/distsql/pom.xml	New parent POM for distsql module
kernel/distsql/handler/pom.xml	New handler module with appropriate dependencies
kernel/distsql/handler/src/main/java/*/.java	Migrated executor implementations with package updates
kernel/distsql/handler/src/test/java/*/.java	Migrated and simplified test files
kernel/distsql/handler/.../DistSQLUpdateExecutor	New SPI registrations for migrated updatable executors
kernel/distsql/handler/.../DistSQLQueryExecutor	New SPI registrations for migrated queryable executors
proxy/backend/core/pom.xml	Added dependency on new distsql-handler module
proxy/backend/core/.../DistSQLUpdateExecutor	Removed SPI registrations for migrated executors
proxy/backend/core/.../DistSQLQueryExecutor	Removed SPI registrations for migrated executors
proxy/backend/core/src/test/java/*/.java	Deleted migrated test files
infra/reachability-metadata/.../reachability-metadata.json	Updated class references for native-image compilation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

linghengqian · 2026-01-28T05:43:25Z

...sql/handler/src/main/java/org/apache/shardingsphere/distsql/handler/rul/PreviewExecutor.java

+    private HintValueContext copyHintValueContext(final HintValueContext hintValueContext) {
+        HintValueContext result = new HintValueContext();
+        result.getShardingDatabaseValues().putAll(hintValueContext.getShardingDatabaseValues());
+        result.getShardingTableValues().putAll(hintValueContext.getShardingTableValues());
+        result.getDisableAuditNames().addAll(hintValueContext.getDisableAuditNames());
+        result.setDataSourceName(hintValueContext.getDataSourceName());
+        result.setDatabaseShardingOnly(hintValueContext.isDatabaseShardingOnly());
+        result.setWriteRouteOnly(hintValueContext.isWriteRouteOnly());
+        result.setSkipSQLRewrite(hintValueContext.isSkipSQLRewrite());
+        result.setShadow(hintValueContext.isShadow());
+        return result;
+    }
+


Please explain why it is necessary to manually copy a new class.

The new helper copies the HintValueContext so we can set skipMetadataValidate without mutating the shared context from the connection (avoids side effects on the original QueryContext). This keeps preview execution isolated. Commit: 1ea8e20.

Initial plan

a65dee8

Copilot AI assigned Copilot and linghengqian Jan 27, 2026

Copilot started work on behalf of linghengqian January 27, 2026 11:54 View session

Copilot AI changed the title ~~[WIP] Migrate DistSQL executors to kernel Maven submodules~~ Plan: migrate proxy DistSQL executors into kernel modules Jan 27, 2026

Copilot AI requested a review from linghengqian January 27, 2026 12:29

Copilot finished work on behalf of linghengqian January 27, 2026 12:29

This comment was marked as outdated.

Sign in to view

Copilot started work on behalf of linghengqian January 27, 2026 12:31 View session

Copilot AI requested a review from linghengqian January 27, 2026 13:10

Copilot finished work on behalf of linghengqian January 27, 2026 13:10

This comment was marked as outdated.

Sign in to view

Copilot started work on behalf of linghengqian January 27, 2026 13:14 View session

Copilot AI requested a review from linghengqian January 27, 2026 14:11

Copilot finished work on behalf of linghengqian January 27, 2026 14:11

This comment was marked as outdated.

Sign in to view

Copilot started work on behalf of linghengqian January 27, 2026 14:16 View session

Copilot AI requested a review from linghengqian January 27, 2026 15:14

Copilot finished work on behalf of linghengqian January 27, 2026 15:14

This comment was marked as outdated.

Sign in to view

Copilot started work on behalf of linghengqian January 27, 2026 15:23 View session

refactor: add kernel distsql handler module

092473d

Co-authored-by: linghengqian <20187731+linghengqian@users.noreply.github.com>

Copilot AI changed the title ~~Plan: migrate proxy DistSQL executors into kernel modules~~ Migrate eligible proxy DistSQL executors into new kernel/distsql module Jan 27, 2026

Copilot AI requested a review from linghengqian January 27, 2026 16:17

Copilot finished work on behalf of linghengqian January 27, 2026 16:17

This comment was marked as outdated.

Sign in to view

Copilot started work on behalf of linghengqian January 27, 2026 16:38 View session

fix: adjust tests for kernel distsql migration

7b1ee08

Co-authored-by: linghengqian <20187731+linghengqian@users.noreply.github.com>

Copilot finished work on behalf of linghengqian January 27, 2026 17:32

Copilot AI requested a review from linghengqian January 27, 2026 17:32

fix: stabilize distsql handler tests

4e113c4

Co-authored-by: linghengqian <20187731+linghengqian@users.noreply.github.com>

Copilot AI requested a review from linghengqian January 28, 2026 03:09

Copilot finished work on behalf of linghengqian January 28, 2026 03:09

This comment was marked as outdated.

Sign in to view

Copilot started work on behalf of linghengqian January 28, 2026 03:17 View session

test: restore distsql executor coverage

b48d4f8

Co-authored-by: linghengqian <20187731+linghengqian@users.noreply.github.com>

Copilot AI requested a review from linghengqian January 28, 2026 04:08

Copilot finished work on behalf of linghengqian January 28, 2026 04:08

This comment was marked as outdated.

Sign in to view

Copilot started work on behalf of linghengqian January 28, 2026 04:22 View session

Copilot AI requested a review from linghengqian January 28, 2026 04:25

Copilot finished work on behalf of linghengqian January 28, 2026 04:25

linghengqian requested changes Jan 28, 2026

View reviewed changes

Copilot started work on behalf of linghengqian January 28, 2026 04:26 View session

refactor: align distsql handler packages

1ea8e20

Co-authored-by: linghengqian <20187731+linghengqian@users.noreply.github.com>

Copilot AI changed the title ~~Migrate eligible proxy DistSQL executors into new kernel/distsql module~~ Align DistSQL handler package layout in kernel/distsql Jan 28, 2026

Copilot AI requested a review from linghengqian January 28, 2026 04:54

Copilot finished work on behalf of linghengqian January 28, 2026 04:54

linghengqian requested a review from Copilot January 28, 2026 05:04

Copilot started reviewing on behalf of linghengqian January 28, 2026 05:04 View session

Copilot AI reviewed Jan 28, 2026

View reviewed changes

linghengqian requested changes Jan 28, 2026

View reviewed changes

Copilot started work on behalf of linghengqian January 28, 2026 05:43 View session

Copilot AI requested a review from linghengqian January 28, 2026 05:45

Copilot finished work on behalf of linghengqian January 28, 2026 05:45

linghengqian closed this Feb 12, 2026

linghengqian deleted the copilot/migrate-distsql-modules branch February 12, 2026 14:10

Conversation

Copilot AI commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes Made

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI commented Jan 28, 2026

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI commented Jan 28, 2026

Uh oh!

This comment was marked as outdated.

Uh oh!

linghengqian left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Jan 28, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

linghengqian Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Jan 27, 2026 •

edited

Loading