fix(react): refresh i18n context identity for React Compiler memoization#2456
Open
yslpn wants to merge 4 commits intolingui:nextfrom
Open
fix(react): refresh i18n context identity for React Compiler memoization#2456yslpn wants to merge 4 commits intolingui:nextfrom
yslpn wants to merge 4 commits intolingui:nextfrom
Conversation
|
@yslpn is attempting to deploy a commit to the Crowdin Team on Vercel. A member of the Team first needs to authorize it. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #2456 +/- ##
===========================================
+ Coverage 76.66% 88.66% +11.99%
===========================================
Files 81 117 +36
Lines 2083 3308 +1225
Branches 532 975 +443
===========================================
+ Hits 1597 2933 +1336
+ Misses 375 337 -38
+ Partials 111 38 -73 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Recreate
i18nreference inI18nProviderviaProxyso memoized React Compiler paths update on locale change.Add a regression test for memoized
useLingui().i18nlocale updates.Avoiding recreating the initial state of the context by passing a function to useState
https://react.dev/reference/react/useState#avoiding-recreating-the-initial-state
Types of changes
Fixes #2343
Checklist