fix: remove empty statements #186
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove empty statements using retain()
Removes empty statements (
Stmt::Empty) from AST after Lingui macro transformations, following SWC ECMAScript Cheatsheet recommendations.Problem
Empty statements remained in output after macro transformation:
Solution
Uses
retain()method instead offilter().collect()for better memory efficiency.Implementation
In
fold_stmts():In
fold_module_items():See: SWC Fold trait
Tests
Added 7 tests in
src/tests/empty_statements.rscovering:Pros and Cons
Pros
retain()is more efficient thanfilter().collect()Cons
Decision
This change is OPTIONAL and not required for core functionality.
The plugin works correctly without removing empty statements. This PR improves output quality following SWC recommendations, but this PR could be close if original code style is preferred.
Results
-All 109 tests pass
retain()vsfilter().collect()