feat: integrate browser-commander for browser operations #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding CLAUDE.md with task information for AI processing. This file will be removed when the task is complete. Issue: #24
Use browser-commander library utilities (CHROME_ARGS) for browser operations. Currently using browser-commander's CHROME_ARGS constants combined with server-specific args until browser-commander adds support for custom args in headless server environments. - Add browser-commander as a dependency - Import and use CHROME_ARGS from browser-commander - Maintain server-specific args (--no-sandbox, etc.) separately - Reference browser-commander issue #11 for future improvements Relates to #24 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
konard
changed the title
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
This reverts commit 04a4075.
Collaborator
Author
🤖 Solution Draft LogThis log file contains the complete execution trace of the AI solution draft process. 💰 Cost estimation:
Now working session is ended, feel free to review and add any feedback on the solution draft. |
Collaborator
Author
|
link-foundation/browser-commander#11 was closed, we can now continue. |
Collaborator
Author
|
🤖 AI Work Session Started Starting automated work session at 2025-12-28T05:17:31.858Z The PR has been converted to draft mode while work is in progress. This comment marks the beginning of an AI work session. Please wait working session to finish, and provide your feedback. |
Now that browser-commander v0.4.0 supports custom Chrome args via the `args` option, we can use its `launchBrowser` function directly instead of maintaining our own browser launch code. Changes: - Update browser-commander dependency from ^0.3.0 to ^0.4.0 - Use launchBrowser from browser-commander for both Puppeteer and Playwright - Pass server-specific args (--no-sandbox, etc.) via the args option - Configure headless: true for server environments - Use unique userDataDir per session to avoid conflicts This fully integrates browser-commander as requested in issue #24. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Collaborator
Author
Full Integration Complete 🎉Now that browser-commander issue #11 has been resolved and v0.4.0 is released, I've updated this PR to fully integrate browser-commander for all browser operations. Changes in this update:
TestsAll CI checks are passing:
The PR is now ready for review. |
Collaborator
Author
🤖 Solution Draft LogThis log file contains the complete execution trace of the AI solution draft process. 💰 Cost estimation:
Now working session is ended, feel free to review and add any feedback on the solution draft. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR integrates the browser-commander library for all browser operations, as requested in issue #24.
Full Integration with browser-commander
With browser-commander v0.4.0 now supporting custom Chrome args via the
argsoption (see issue #11), we can now fully use itslaunchBrowserfunction for both Puppeteer and Playwright operations.Key changes:
launchBrowserfrom browser-commander for all browser launches--no-sandbox,--disable-setuid-sandbox,--disable-dev-shm-usage) via theargsoptionheadless: truefor server environmentsuserDataDirper session to avoid conflictsChanges
package.jsonbrowser-commanderfrom^0.3.0to^0.4.0src/browser.jslaunchBrowserfrom browser-commander- Use
launchBrowserfor both Puppeteer and Playwright- Pass custom args, headless mode, and unique userDataDir
- Removed direct puppeteer/playwright imports
Test Results
All relevant tests pass:
getBrowserEnginefunction/imagewhich uses Puppeteer)Playwright tests require Playwright browsers to be installed, which is expected for CI environments without Playwright binaries.
Related Issues
🤖 Generated with Claude Code