fix: PlaywrightAdapter.evaluateOnPage() spread multiple arguments correctly#16
Merged
fix: PlaywrightAdapter.evaluateOnPage() spread multiple arguments correctly#16
Conversation
Adding CLAUDE.md with task information for AI processing. This file will be removed when the task is complete. Issue: #15
…rectly When multiple arguments are passed to evaluateOnPage(), they are now properly spread to the function in the browser context, matching Puppeteer's behavior. The fix wraps the function and passes args as a single object with fnStr and argsArray, then reconstructs and calls the function with spread arguments in the browser context. Fixes #15 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This reverts commit 2b73dc0.
Member
Author
🤖 Solution Draft LogThis log file contains the complete execution trace of the AI solution draft process. 💰 Cost estimation:
Now working session is ended, feel free to review and add any feedback on the solution draft. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
PlaywrightAdapter.evaluateOnPage()to correctly spread multiple arguments to the function in the browser context, matching Puppeteer's behavior.Root Cause:
Playwright's
page.evaluate()only accepts a single argument. When multiple args are passed, the function was receiving the entire array as its first parameter instead of spread arguments.Solution:
When multiple arguments are passed, the fix:
page.evaluate()Changes
PlaywrightAdapter.evaluateOnPage()to spread multiple arguments correctlyTest Plan
Fixes #15
🤖 Generated with Claude Code