feat: add Playwright text selector support and use TIMING constants#8
Merged
feat: add Playwright text selector support and use TIMING constants#8
Conversation
Adding CLAUDE.md with task information for AI processing. This file will be removed when the task is complete. Issue: #7
This PR adopts improvements from hh-job-application-automation: ## Changes ### New Playwright text selector support (`selectors.js`) - Add `isPlaywrightTextSelector()` to detect `:has-text()` and `:text-is()` selectors - Add `parsePlaywrightTextSelector()` to extract base selector and text content - Update `normalizeSelector()` to convert Playwright text selectors to valid CSS selectors - Update `withTextSelectorSupport()` to handle Playwright text selectors in addition to Puppeteer ### Use constants for timing values - Add `NAVIGATION_TIMEOUT` constant (30000ms) to `constants.js` - Update `navigation-manager.js` to use `TIMING.NAVIGATION_TIMEOUT` - Update `bindings.js` to pass `engine` parameter to `normalizeSelector()` ## Why The upstream hh-job-application-automation repository has battle-tested improvements for handling Playwright's text pseudo-selectors (`:has-text()`, `:text-is()`) which are valid for Playwright's locator API but not for `document.querySelectorAll`. These selectors are now properly normalized to valid CSS selectors. Fixes #7 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This reverts commit d40e36f.
Member
Author
🤖 Solution Draft LogThis log file contains the complete execution trace of the AI solution draft process. 💰 Cost estimation:
Now working session is ended, feel free to review and add any feedback on the solution draft. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adopts improvements from https://github.com/konard/hh-job-application-automation (as requested in #7):
isPlaywrightTextSelector()andparsePlaywrightTextSelector()to properly handle Playwright's:has-text()and:text-is()pseudo-selectorsnormalizeSelector(): Now converts Playwright text selectors to valid CSS selectors for browser context operationswithTextSelectorSupport(): Extended to handle Playwright text selectors in addition to Puppeteer text selector objectsNAVIGATION_TIMEOUTconstant and updated navigation-manager to use it instead of hardcoded valuesWhy These Changes
The upstream
hh-job-application-automationrepository has battle-tested improvements for handling Playwright's text pseudo-selectors. These selectors (:has-text(),:text-is()) are valid for Playwright's locator API but not fordocument.querySelectorAll. The changes properly normalize these selectors to valid CSS selectors by:page.evaluate()to find matching elementsdata-qaattribute ornth-of-type)Test Plan
Fixes #7
🤖 Generated with Claude Code