fix(ci): Remove CI/CD check differences between PR and push events#4
Merged
fix(ci): Remove CI/CD check differences between PR and push events#4
Conversation
Adding CLAUDE.md with task information for AI processing. This file will be removed when the task is complete. Issue: #3
- Add detect-changes job with cross-platform detect-code-changes.mjs script - Make lint job independent of changeset-check (runs based on file changes only) - Allow docs-only PRs without changeset requirement - Handle changeset-check 'skipped' state in dependent jobs - Exclude .changeset/, docs/, experiments/, examples/ folders and markdown files from code changes detection Fixes #3 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Use 'my-package' instead of 'java-ai-driven-development-pipeline-template' in changeset - Remove extra blank lines from CHANGELOG.md to pass Spotless check 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The file requires a trailing newline for Spotless check to pass. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This reverts commit 04e9468.
Member
Author
🤖 Solution Draft LogThis log file contains the complete execution trace of the AI solution draft process. 💰 Cost estimation:
Now working session is ended, feel free to review and add any feedback on the solution draft. |
Member
Author
|
In template we need to have tests only for single latest version of Java. |
Member
Author
|
🤖 AI Work Session Started Starting automated work session at 2025-12-29T14:35:39.104Z The PR has been converted to draft mode while work is in progress. This comment marks the beginning of an AI work session. Please wait working session to finish, and provide your feedback. |
- Change CI test matrix from Java 17+21 to Java 21 only - Update env.JAVA_VERSION to 21 for consistency across workflow - Update Codecov upload condition to match new Java version This simplifies the template CI by testing only on the latest Java version, as requested for the template repository. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Member
Author
🤖 Solution Draft LogThis log file contains the complete execution trace of the AI solution draft process. 💰 Cost estimation:
Now working session is ended, feel free to review and add any feedback on the solution draft. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR applies best practices from js-ai-driven-development-pipeline-template#18 to fix the issue where CI/CD checks behave differently for pull request events vs push/merge events.
Root Cause
When documentation-only PRs are merged without changesets:
changeset-checkjob fails with "No changeset found"lint, which could fail on unformatted filesChanges
New Script:
scripts/detect-code-changes.mjs- a cross-platform Node.js script for detecting file changes in CI/CDWorkflow Changes:
detect-changesjob that runs the new script and outputs what types of files changedlintjob independent ofchangeset-check- it's a fast check that should always runchangeset-checkskip for docs-only PRs by adding condition:needs.detect-changes.outputs.any-code-changed == 'true'|| needs.changeset-check.result == 'skipped'totestjob to handle the new skipped stateany-code-changeddetection to exclude:.changeset/folder (changeset metadata)docs/folder (documentation)experiments/folder (experimental scripts)examples/folder (example scripts)*.md) in any folderBenefits
After this fix:
Testing
CI checks:
Files Changed
.github/workflows/release.yml- Workflow structure updates + use new script + Java 21 onlyscripts/detect-code-changes.mjs- NEW Cross-platform change detection script.changeset/fix-ci-workflow-dependencies.md- Changeset for releaseCHANGELOG.md- Minor formatting fix (removed extra blank lines)Fixes #3
🤖 Generated with Claude Code
Co-Authored-By: Claude Opus 4.5 noreply@anthropic.com