Updating to newest release

LinkDotNet Bot · LinkDotNet Bot · commit a4e3c5eeafa4 · 2024-03-02T12:35:28.000Z
diff --git a/.github/dependabot.yml b/.github/dependabot.yml
@@ -8,9 +8,9 @@ updates:
   - package-ecosystem: "nuget" # See documentation for possible values
     directory: "/" # Location of package manifests
     schedule:
-      interval: "daily"
+      interval: "monthly"
       
   - package-ecosystem: "github-actions"
     directory: "/"
     schedule:
-      interval: "daily"
+      interval: "monthly"
diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml
@@ -24,18 +24,19 @@ jobs:
       - name: Checkout repository
         uses: actions/checkout@v4.1.1
 
-      - uses: actions/setup-dotnet@v3.2.0
+      - uses: actions/setup-dotnet@v4.0.0
         with:
           dotnet-version: | 
             6.0.x
             7.0.x
             8.0.x
+            9.0.x
 
       - name: Initialize CodeQL
-        uses: github/codeql-action/init@v2
+        uses: github/codeql-action/init@v3
 
       - name: Autobuild
-        uses: github/codeql-action/autobuild@v2
+        uses: github/codeql-action/autobuild@v3
 
       - name: Perform CodeQL Analysis
-        uses: github/codeql-action/analyze@v2
+        uses: github/codeql-action/analyze@v3
diff --git a/.github/workflows/create-release.yml b/.github/workflows/create-release.yml
@@ -34,15 +34,16 @@ jobs:
         path: ./CHANGELOG.md
 
     - name: Setup dotnet
-      uses: actions/setup-dotnet@v3.2.0
+      uses: actions/setup-dotnet@v4.0.0
       with:
         dotnet-version: | 
           6.0.x
           7.0.x
           8.0.x
+          9.0.x
 
     - name: Update CHANGELOG file
-      uses: thomaseizinger/keep-a-changelog-new-release@1.3.0
+      uses: thomaseizinger/keep-a-changelog-new-release@2.0.0
       with:
         version: ${{ github.event.inputs.versionIncrement }}
 
diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml
@@ -15,12 +15,13 @@ jobs:
     - uses: actions/checkout@v4.1.1
 
     - name: Setup .NET
-      uses: actions/setup-dotnet@v3.2.0
+      uses: actions/setup-dotnet@v4.0.0
       with:
         dotnet-version: | 
           6.0.x
           7.0.x
           8.0.x
+          9.0.x
 
     - name: Setup DocFX
       uses: crazy-max/ghaction-chocolatey@v3.0.0
diff --git a/.github/workflows/dotnet.yml b/.github/workflows/dotnet.yml
@@ -14,12 +14,14 @@ jobs:
     steps:
     - uses: actions/checkout@v4.1.1
     - name: Setup .NET
-      uses: actions/setup-dotnet@v3.2.0
+      uses: actions/setup-dotnet@v4.0.0
       with:
         dotnet-version: | 
           6.0.x
           7.0.x
           8.0.x
+          9.0.x
+          
     - name: Setup color
       run: |
         echo "DOTNET_SYSTEM_CONSOLE_ALLOW_ANSI_COLOR_REDIRECTION=1" >> $GITHUB_ENV
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,13 @@ All notable changes to **ValueStringBuilder** will be documented in this file. T
 
 ## [Unreleased]
 
+## [1.19.0] - 2024-03-02
+
+## Added
+
+-   Support for `net9.0`
+-   New `Append` overload that accepts a single character
+
 ## [1.18.6] - 2023-11-03
 
 ### Changed
@@ -381,7 +388,9 @@ This release brings extensions to the `ValueStringBuilder` API. For `v1.0` the `
 
 -   Initial release
 
-[Unreleased]: https://github.com/linkdotnet/StringBuilder/compare/1.18.6...HEAD
+[Unreleased]: https://github.com/linkdotnet/StringBuilder/compare/1.19.0...HEAD
+
+[1.19.0]: https://github.com/linkdotnet/StringBuilder/compare/1.18.6...1.19.0
 
 [1.18.6]: https://github.com/linkdotnet/StringBuilder/compare/1.18.5...1.18.6
 
diff --git a/Directory.Build.props b/Directory.Build.props
@@ -1,11 +1,11 @@
 <?xml version="1.0" encoding="utf-8"?>
 <Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
 	<ItemGroup>
-      <PackageReference Include="SonarAnalyzer.CSharp" Version="9.12.0.78982">
+      <PackageReference Include="SonarAnalyzer.CSharp" Version="9.19.0.84025">
         <PrivateAssets>all</PrivateAssets>
         <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
       </PackageReference>
-      <PackageReference Include="StyleCop.Analyzers" Version="1.2.0-beta.507">
+      <PackageReference Include="StyleCop.Analyzers" Version="1.2.0-beta.556">
         <PrivateAssets>all</PrivateAssets>
         <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
       </PackageReference>
diff --git a/src/LinkDotNet.StringBuilder/LinkDotNet.StringBuilder.csproj b/src/LinkDotNet.StringBuilder/LinkDotNet.StringBuilder.csproj
@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
     <PropertyGroup>
-        <TargetFrameworks>net6.0;net7.0;net8.0</TargetFrameworks>
+        <TargetFrameworks>net6.0;net7.0;net8.0;net9.0</TargetFrameworks>
         <ImplicitUsings>enable</ImplicitUsings>
         <Nullable>enable</Nullable>
         <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
@@ -40,11 +40,11 @@
 	</PropertyGroup>
 
     <ItemGroup>
-      <PackageReference Include="Meziantou.Analyzer" Version="2.0.103">
+      <PackageReference Include="Meziantou.Analyzer" Version="2.0.145">
         <PrivateAssets>all</PrivateAssets>
         <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
       </PackageReference>
-      <PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1">
+      <PackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0">
         <PrivateAssets>all</PrivateAssets>
         <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
       </PackageReference>
diff --git a/src/LinkDotNet.StringBuilder/ValueStringBuilder.Append.cs b/src/LinkDotNet.StringBuilder/ValueStringBuilder.Append.cs
@@ -75,21 +75,39 @@ public unsafe void Append(char* value, int length)
     }
 
     /// <summary>
-    /// Adds the default new line separator.
+    /// Appends a slice of memory.
     /// </summary>
+    /// <param name="memory">The memory to add.</param>
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    public void AppendLine()
+    public void Append(ReadOnlyMemory<char> memory)
     {
-        Append(Environment.NewLine);
+        Append(memory.Span);
     }
 
     /// <summary>
-    /// Appends a slice of memory.
+    /// Appends a single character to the string builder.
     /// </summary>
-    /// <param name="memory">The memory to add.</param>
-    public void Append(ReadOnlyMemory<char> memory)
+    /// <param name="value">Character to add.</param>
+    [MethodImpl(MethodImplOptions.AggressiveInlining)]
+    public void Append(char value)
     {
-        Append(memory.Span);
+        var newSize = bufferPosition + 1;
+        if (newSize > buffer.Length)
+        {
+            Grow(newSize);
+        }
+
+        buffer[bufferPosition] = value;
+        bufferPosition++;
+    }
+
+    /// <summary>
+    /// Adds the default new line separator.
+    /// </summary>
+    [MethodImpl(MethodImplOptions.AggressiveInlining)]
+    public void AppendLine()
+    {
+        Append(Environment.NewLine);
     }
 
     /// <summary>
diff --git a/src/LinkDotNet.StringBuilder/ValueStringBuilder.AppendJoin.cs b/src/LinkDotNet.StringBuilder/ValueStringBuilder.AppendJoin.cs
@@ -55,7 +55,7 @@ private void AppendJoinInternalString<T>(ReadOnlySpan<char> separator, IEnumerab
         }
 
         var current = enumerator.Current;
-        if (current != null)
+        if (current is not null)
         {
             AppendInternal(current);
         }
diff --git a/src/LinkDotNet.StringBuilder/ValueStringBuilder.cs b/src/LinkDotNet.StringBuilder/ValueStringBuilder.cs
@@ -288,7 +288,7 @@ public readonly int LastIndexOf(ReadOnlySpan<char> word, int startIndex)
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
     public void Dispose()
     {
-        if (arrayFromPool != null)
+        if (arrayFromPool is not null)
         {
             ArrayPool<char>.Shared.Return(arrayFromPool);
         }
@@ -328,7 +328,7 @@ ref Unsafe.As<char, byte>(ref sourceRef),
         var oldBufferFromPool = arrayFromPool;
         buffer = arrayFromPool = rented;
 
-        if (oldBufferFromPool != null)
+        if (oldBufferFromPool is not null)
         {
             ArrayPool<char>.Shared.Return(oldBufferFromPool);
         }
diff --git a/tests/LinkDotNet.StringBuilder.Benchmarks/LinkDotNet.StringBuilder.Benchmarks.csproj b/tests/LinkDotNet.StringBuilder.Benchmarks/LinkDotNet.StringBuilder.Benchmarks.csproj
@@ -9,7 +9,7 @@
     </PropertyGroup>
 
     <ItemGroup>
-      <PackageReference Include="BenchmarkDotNet" Version="0.13.10" />
+      <PackageReference Include="BenchmarkDotNet" Version="0.13.12" />
     </ItemGroup>
 
     <ItemGroup>
diff --git a/tests/LinkDotNet.StringBuilder.UnitTests/LinkDotNet.StringBuilder.UnitTests.csproj b/tests/LinkDotNet.StringBuilder.UnitTests/LinkDotNet.StringBuilder.UnitTests.csproj
@@ -1,21 +1,21 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
     <PropertyGroup>
-        <TargetFrameworks>net6.0;net7.0;net8.0</TargetFrameworks>
+        <TargetFrameworks>net6.0;net7.0;net8.0;net9.0</TargetFrameworks>
         <Nullable>enable</Nullable>
         <IsPackable>false</IsPackable>
         <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
     </PropertyGroup>
 
     <ItemGroup>
         <PackageReference Include="FluentAssertions" Version="6.12.0" />
-        <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.7.2" />
-        <PackageReference Include="xunit" Version="2.6.1" />
-        <PackageReference Include="xunit.runner.visualstudio" Version="2.5.3">
+        <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.9.0" />
+        <PackageReference Include="xunit" Version="2.7.0" />
+        <PackageReference Include="xunit.runner.visualstudio" Version="2.5.7">
             <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
             <PrivateAssets>all</PrivateAssets>
         </PackageReference>
-        <PackageReference Include="coverlet.collector" Version="6.0.0">
+        <PackageReference Include="coverlet.collector" Version="6.0.1">
             <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
             <PrivateAssets>all</PrivateAssets>
         </PackageReference>
diff --git a/tests/LinkDotNet.StringBuilder.UnitTests/ValueStringBuilder.Append.Tests.cs b/tests/LinkDotNet.StringBuilder.UnitTests/ValueStringBuilder.Append.Tests.cs
@@ -196,4 +196,27 @@ public void GivenMultipleValues_WhenCallingAppend_NotCrashing()
 
         builder.ToString().Should().NotBeNull();
     }
+
+    [Fact]
+    public void GivenStringBuilder_WhenAddingSingleCharacter_ThenShouldBeAdded()
+    {
+        using var builder = new ValueStringBuilder();
+        builder.Append('c');
+
+        builder.ToString().Should().Be("c");
+    }
+
+    [Fact]
+    public void GivenStringBuilder_WhenAddingIncreasinglyLargerStrings_ThenShouldBeAdded()
+    {
+        using var builder = new ValueStringBuilder();
+        builder.Append(new string('a', 256));
+        builder.Append(new string('b', 512));
+        builder.Append(new string('c', 1024));
+        builder.Append(new string('d', 2048));
+        builder.Append(new string('e', 4096));
+        builder.Append(new string('f', 8192));
+
+        builder.ToString().Should().MatchRegex("[a]{256}[b]{512}[c]{1024}[d]{2048}[e]{4096}[f]{8192}");
+    }
 }
diff --git a/tests/LinkDotNet.StringBuilder.UnitTests/ValueStringBuilder.Replace.Tests.cs b/tests/LinkDotNet.StringBuilder.UnitTests/ValueStringBuilder.Replace.Tests.cs
@@ -1,4 +1,5 @@
 using System;
+using System.Linq;
 
 namespace LinkDotNet.StringBuilder.UnitTests;
 
@@ -7,12 +8,11 @@ public class ValueStringBuilderReplaceTests
     [Fact]
     public void ShouldReplaceAllCharacters()
     {
-        using var builder = new ValueStringBuilder();
-        builder.Append("CCCC");
+        using var builder = new ValueStringBuilder(new string('C', 100));
 
         builder.Replace('C', 'B');
 
-        builder.ToString().Should().Be("BBBB");
+        builder.ToString().Should().MatchRegex("[B]{100}");
     }
 
     [Fact]
@@ -178,6 +178,17 @@ public void ShouldReplaceNonISpanFormattableInSlice()
         builder.ToString().Should().Be("HelloHello{0}");
     }
 
+    [Fact]
+    public void ShouldReplaceAllOccurrences()
+    {
+        var content = string.Join(string.Empty, Enumerable.Range(0, 100).Select(_ => "AB"));
+        using var builder = new ValueStringBuilder(content);
+
+        builder.Replace("A", "C");
+
+        builder.ToString().Should().MatchRegex("[CB]{100}");
+    }
+
     private struct MyStruct
     {
         public override string ToString() => "Hello";

Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@ private void AppendJoinInternalString<T>(ReadOnlySpan<char> separator, IEnumerab`
`55`	`55`	`}`
`56`	`56`
`57`	`57`	`var current = enumerator.Current;`
`58`		`- if (current != null)`
	`58`	`+ if (current is not null)`
`59`	`59`	`{`
`60`	`60`	`AppendInternal(current);`
`61`	`61`	`}`