Skip to content

Prepare for v2 #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 2, 2025
Merged

Prepare for v2 #197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
175f50b
Prepare for v2
linkdotnet Aug 30, 2024
76c7bba
chore: Use xunit.v3
linkdotnet Jan 2, 2025
438d414
fix: Use Overload resolution for Span ctor (fixes #210)
linkdotnet Jan 2, 2025
8bf8d1b
docs: added changelog entry
linkdotnet Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/codeql.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,6 @@ jobs:
- uses: actions/[email protected]
with:
dotnet-version: |
6.0.x
7.0.x
8.0.x
9.0.x

Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/create-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@ jobs:
uses: actions/[email protected]
with:
dotnet-version: |
6.0.x
7.0.x
8.0.x
9.0.x

Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@ jobs:
uses: actions/[email protected]
with:
dotnet-version: |
6.0.x
7.0.x
8.0.x
9.0.x

Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/dotnet.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@ jobs:
uses: actions/[email protected]
with:
dotnet-version: |
6.0.x
7.0.x
8.0.x
9.0.x

Expand Down
8 changes: 8 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,14 @@ All notable changes to **ValueStringBuilder** will be documented in this file. T

## [Unreleased]

This is the `v2` release of the **ValueStringBuilder**. There aren't any noticeable changes. Only old framework versions were removed to make further development easier.

### Removed
- Support for `net6.0` and `net7.0` was removed.

### Changed
- Added `OverloadResolutionPriority` for `Span` overload for the ctor to keep the current behavior. Reported by [@nsentinel])(https://github.com/nsentinel) in [#210](https://github.com/linkdotnet/StringBuilder/issues/210).

## [1.22.0] - 2024-12-18

### Added
Expand Down
2 changes: 1 addition & 1 deletion src/LinkDotNet.StringBuilder/LinkDotNet.StringBuilder.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>net6.0;net7.0;net8.0;net9.0</TargetFrameworks>
<TargetFrameworks>net8.0;net9.0</TargetFrameworks>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
Expand Down
26 changes: 0 additions & 26 deletions src/LinkDotNet.StringBuilder/StringSyntaxAttribute.cs
View file
Open in desktop

This file was deleted.

3 changes: 3 additions & 0 deletions src/LinkDotNet.StringBuilder/ValueStringBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@ public ValueStringBuilder()
/// </summary>
/// <param name="initialBuffer">Initial buffer for the string builder to begin with.</param>
[MethodImpl(MethodImplOptions.AggressiveInlining)]
#if NET9_0_OR_GREATER
[OverloadResolutionPriority(1)]
#endif
public ValueStringBuilder(Span<char> initialBuffer)
{
bufferPosition = 0;
Expand Down
2 changes: 1 addition & 1 deletion tests/LinkDotNet.StringBuilder.Benchmarks/LinkDotNet.StringBuilder.Benchmarks.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net8.0</TargetFramework>
<TargetFramework>net9.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<IsPackable>false</IsPackable>
Expand Down
6 changes: 3 additions & 3 deletions tests/LinkDotNet.StringBuilder.UnitTests/LinkDotNet.StringBuilder.UnitTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>net6.0;net7.0;net8.0;net9.0</TargetFrameworks>
<TargetFrameworks>net8.0;net9.0</TargetFrameworks>
<Nullable>enable</Nullable>
<IsPackable>false</IsPackable>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
Expand All @@ -10,8 +10,8 @@
<ItemGroup>
<PackageReference Include="FluentAssertions" Version="7.0.0" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.12.0" />
<PackageReference Include="xunit" Version="2.9.2" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.8.2">
<PackageReference Include="xunit.v3" Version="1.0.0" />
<PackageReference Include="xunit.runner.visualstudio" Version="3.0.0">
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
Expand Down
Loading